From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F64AFA3728 for ; Wed, 16 Oct 2019 10:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38B89218DE for ; Wed, 16 Oct 2019 10:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730251AbfJPK4f (ORCPT ); Wed, 16 Oct 2019 06:56:35 -0400 Received: from mga18.intel.com ([134.134.136.126]:44164 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfJPK4f (ORCPT ); Wed, 16 Oct 2019 06:56:35 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 03:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,303,1566889200"; d="scan'208";a="189643967" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.130]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2019 03:56:32 -0700 Date: Wed, 16 Oct 2019 13:56:31 +0300 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel , linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] efi/tpm: return -EINVAL when determining tpm final events log size fails Message-ID: <20191016105631.GD10184@linux.intel.com> References: <20191014172145.9669-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014172145.9669-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Oct 14, 2019 at 10:21:45AM -0700, Jerry Snitselaar wrote: > Currently nothing checks the return value of efi_tpm_eventlog_init, > but in case that changes in the future make sure an error is > returned when it fails to determine the tpm final events log > size. > > Cc: Ard Biesheuvel > Cc: Jarkko Sakkinen > Cc: linux-efi@vger.kernel.org > Cc: linux-integrity@vger.kernel.org > Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") > Suggested-by: Dan Carpenter > Signed-off-by: Jerry Snitselaar Reviewed-by: Jarkko Sakkinen /Jarkko