From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77D3FA3728 for ; Wed, 16 Oct 2019 16:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF5521A49 for ; Wed, 16 Oct 2019 16:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404337AbfJPQ2E (ORCPT ); Wed, 16 Oct 2019 12:28:04 -0400 Received: from mga14.intel.com ([192.55.52.115]:36565 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404133AbfJPQ2E (ORCPT ); Wed, 16 Oct 2019 12:28:04 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 09:28:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,304,1566889200"; d="scan'208";a="202116750" Received: from hagarwal-mobl1.gar.corp.intel.com (HELO localhost) ([10.252.5.165]) by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2019 09:27:58 -0700 Date: Wed, 16 Oct 2019 19:27:57 +0300 From: Jarkko Sakkinen To: Joe Perches Cc: Borislav Petkov , Kairui Song , linux-kernel@vger.kernel.org, Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , Matthew Garrett , Baoquan He , Dave Young , x86@kernel.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v3] x86, efi: never relocate kernel below lowest acceptable address Message-ID: <20191016162757.GC6279@linux.intel.com> References: <20191012034421.25027-1-kasong@redhat.com> <20191014101419.GA4715@zn.tnic> <20191014202111.GP15552@linux.intel.com> <20191014211825.GJ4715@zn.tnic> <20191016152014.GC4261@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Oct 16, 2019 at 08:23:56AM -0700, Joe Perches wrote: > On Wed, 2019-10-16 at 18:20 +0300, Jarkko Sakkinen wrote: > > On Mon, Oct 14, 2019 at 11:18:25PM +0200, Borislav Petkov wrote: > > > On Mon, Oct 14, 2019 at 11:21:11PM +0300, Jarkko Sakkinen wrote: > > > > Was there a section in the patch submission documentation to point out > > > > when people send patches with all the possible twists for an acronym? > > > > > > I don't think so. > > > > > > > This is giving me constantly gray hairs with TPM patches. > > > > > > Well, I'm slowly getting tired of repeating the same crap over and over > > > again about how important it is to document one's changes and to write > > > good commit messages. The most repeated answers I'm simply putting into > > > canned reply templates because, well, saying it once or twice is not > > > enough anymore. :-\ > > > > > > And yeah, I see your pain. Same here, actually. > > > > > > In the acronym case, I'd probably add a regex to my patch massaging > > > script and convert those typos automatically and be done with it. > > > > Wonder if checkpatch.pl could be extended to know acronyms e.g. have a > > db of known acronyms. > > ? examples please. > > checkpatch has a db for misspellings, I supposed another for > acronyms could be added, but how would false positives be avoided? TPM should be always TPM, e.g. not tpm. EFI should be always, e.g. not efi. /Jarkko