From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49B5CA9EBC for ; Thu, 24 Oct 2019 14:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE10021A4A for ; Thu, 24 Oct 2019 14:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502857AbfJXOZZ (ORCPT ); Thu, 24 Oct 2019 10:25:25 -0400 Received: from mga09.intel.com ([134.134.136.24]:30057 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732393AbfJXOZY (ORCPT ); Thu, 24 Oct 2019 10:25:24 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 07:25:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,224,1569308400"; d="scan'208";a="210400556" Received: from vapodrez-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.8.212]) by orsmga002.jf.intel.com with ESMTP; 24 Oct 2019 07:25:20 -0700 Date: Thu, 24 Oct 2019 17:25:19 +0300 From: Jarkko Sakkinen To: Hans de Goede Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] tpm: Switch to platform_get_irq_optional() Message-ID: <20191024142519.GA3881@linux.intel.com> References: <20191019094528.27850-1-hdegoede@redhat.com> <20191021154942.GB4525@linux.intel.com> <80409d36-53fa-d159-d864-51b8495dc306@redhat.com> <20191023113733.GB21973@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Oct 23, 2019 at 04:32:57PM +0200, Hans de Goede wrote: > Hi, > > On 23-10-2019 13:37, Jarkko Sakkinen wrote: > > On Mon, Oct 21, 2019 at 05:56:56PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 21-10-2019 17:49, Jarkko Sakkinen wrote: > > > > On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote: > > > > > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to > > > > > platform_get_irq*()"), platform_get_irq() will call dev_err() on an error, > > > > > as the IRQ usage in the tpm_tis driver is optional, this is undesirable. > > > > > > > > > > Specifically this leads to this new false-positive error being logged: > > > > > [ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found > > > > > > > > > > This commit switches to platform_get_irq_optional(), which does not log > > > > > an error, fixing this. > > > > > > > > > > Cc: # 5.4.x > > > > > > > > Incorrect format (should be wo '<' and '>'). > > > > > > According to: > > > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > > the '<' and '>' should be added when adding a # > > > > OK, right so it was. This first patch that I'm reviewing with such > > commit. > > > > > > Also, not sure why this should be backported to stable kernel anyway. > > > > > > Because false-positive error messages are bad and cause users to > > > file false-positive bug-reports. > > > > Neither categorizes into a regression albeit being unfortunate > > glitches. > > The stable series also does other small fixes, such as adding new > pci/usb-ids, etc. This clearly falls within this. IMHO ideally this > should go to a 5.4-rc# making the whole discussion moot, but since > I was afraid it would not make 5.4, I added the Cc: stable. I get adding PCI/USB id as it extends the hardware support for the stable kernel without risking its stability. This patch is factors less useful. /Jarkko