From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8EAC432C0 for ; Mon, 18 Nov 2019 18:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2044421939 for ; Mon, 18 Nov 2019 18:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbfKRSH6 (ORCPT ); Mon, 18 Nov 2019 13:07:58 -0500 Received: from mga09.intel.com ([134.134.136.24]:52329 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfKRSH6 (ORCPT ); Mon, 18 Nov 2019 13:07:58 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 10:07:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,321,1569308400"; d="scan'208";a="380735807" Received: from cooperwu-mobl.gar.corp.intel.com (HELO localhost) ([10.252.3.195]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 10:07:54 -0800 Date: Mon, 18 Nov 2019 20:07:53 +0200 From: Jarkko Sakkinen To: David Binderman Cc: Greg KH , "peterhuewe@gmx.de" , "jgg@ziepe.ca" , Arnd Bergmann , "linux-integrity@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check Message-ID: <20191118180753.GE5984@linux.intel.com> References: <20191118092721.GA154812@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Nov 18, 2019 at 09:42:01AM +0000, David Binderman wrote: > Hello there Greg, > > >Great, how about you submit a patch to resolve this?  That way you can > >get the full credit for finding and resolveing the issue? > > No thanks. I gave up bothering to send in patches when I found > out my emails cc'ing to the linux kernel mailing list get bounced. > I am happy for someone else to invent a patch. > > BTW, more of the same here: > > linux-5.4-rc8/drivers/char/tpm/tpm_infineon.c:173:10: style: Variable 'status' is reassigned a value before the old one has been used. [redundantAssignment] > > > Regards > > David I'm fine with adding reported-by from you unless you want to send a fix. I'll create a fix after 5.5-rc1 is out. /Jarkko