* Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check [not found] <DB7PR08MB3801D9F4D5822D36E57282F39C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com> @ 2019-11-18 9:27 ` Greg KH [not found] ` <DB7PR08MB38017F9C07DA5D40B3133AED9C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com> 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2019-11-18 9:27 UTC (permalink / raw) To: David Binderman Cc: peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca, Arnd Bergmann, linux-integrity@vger.kernel.org, Linux Kernel Mailing List On Mon, Nov 18, 2019 at 09:24:32AM +0000, David Binderman wrote: > Hello there, > > linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735:5: style: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment] > > Source code is > > if (tpm_suspend_pcr) > rc = tpm1_pcr_extend(chip, tpm_suspend_pcr, dummy_hash, > "extending dummy pcr before suspend"); > > rc = tpm_buf_init(&buf, TPM_TAG_RQU_COMMAND, TPM_ORD_SAVESTATE); > > Suggest add test of rc after call to tpm1_pcr_extend. Great, how about you submit a patch to resolve this? That way you can get the full credit for finding and resolveing the issue? thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <DB7PR08MB38017F9C07DA5D40B3133AED9C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com>]
* Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check [not found] ` <DB7PR08MB38017F9C07DA5D40B3133AED9C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com> @ 2019-11-18 11:22 ` Greg KH 2019-11-18 18:07 ` Jarkko Sakkinen 1 sibling, 0 replies; 3+ messages in thread From: Greg KH @ 2019-11-18 11:22 UTC (permalink / raw) To: David Binderman Cc: peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca, Arnd Bergmann, linux-integrity@vger.kernel.org, Linux Kernel Mailing List On Mon, Nov 18, 2019 at 09:42:01AM +0000, David Binderman wrote: > Hello there Greg, > > >Great, how about you submit a patch to resolve this? That way you can > >get the full credit for finding and resolveing the issue? > > No thanks. I gave up bothering to send in patches when I found > out my emails cc'ing to the linux kernel mailing list get bounced. Yes, hotmail.com emails have been rejected from there for many years. If you wish to contribute to the kernel you need to use a different email domain, sorry. good luck! greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check [not found] ` <DB7PR08MB38017F9C07DA5D40B3133AED9C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com> 2019-11-18 11:22 ` Greg KH @ 2019-11-18 18:07 ` Jarkko Sakkinen 1 sibling, 0 replies; 3+ messages in thread From: Jarkko Sakkinen @ 2019-11-18 18:07 UTC (permalink / raw) To: David Binderman Cc: Greg KH, peterhuewe@gmx.de, jgg@ziepe.ca, Arnd Bergmann, linux-integrity@vger.kernel.org, Linux Kernel Mailing List On Mon, Nov 18, 2019 at 09:42:01AM +0000, David Binderman wrote: > Hello there Greg, > > >Great, how about you submit a patch to resolve this? That way you can > >get the full credit for finding and resolveing the issue? > > No thanks. I gave up bothering to send in patches when I found > out my emails cc'ing to the linux kernel mailing list get bounced. > I am happy for someone else to invent a patch. > > BTW, more of the same here: > > linux-5.4-rc8/drivers/char/tpm/tpm_infineon.c:173:10: style: Variable 'status' is reassigned a value before the old one has been used. [redundantAssignment] > > > Regards > > David I'm fine with adding reported-by from you unless you want to send a fix. I'll create a fix after 5.5-rc1 is out. /Jarkko ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-18 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DB7PR08MB3801D9F4D5822D36E57282F39C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-11-18 9:27 ` linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check Greg KH
[not found] ` <DB7PR08MB38017F9C07DA5D40B3133AED9C4D0@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-11-18 11:22 ` Greg KH
2019-11-18 18:07 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).