From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2FEC432C3 for ; Fri, 29 Nov 2019 23:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6720A206BF for ; Fri, 29 Nov 2019 23:51:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbfK2Xvi (ORCPT ); Fri, 29 Nov 2019 18:51:38 -0500 Received: from mga03.intel.com ([134.134.136.65]:16353 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbfK2Xvh (ORCPT ); Fri, 29 Nov 2019 18:51:37 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 15:51:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,259,1571727600"; d="scan'208";a="241184315" Received: from gamanzi-mobl4.ger.corp.intel.com (HELO localhost) ([10.252.3.126]) by fmsmga002.fm.intel.com with ESMTP; 29 Nov 2019 15:51:32 -0800 Date: Sat, 30 Nov 2019 01:51:31 +0200 From: Jarkko Sakkinen To: linux-kernel@vger.kernel.org, Mimi Zohar , Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org Subject: Re: [PATCH v4] tpm: Add tpm_version_major sysfs file Message-ID: <20191129235131.GA21546@linux.intel.com> References: <20191030225843.23366-1-jsnitsel@redhat.com> <20191128010826.w4ixlix3s3ovta3m@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191128010826.w4ixlix3s3ovta3m@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Nov 27, 2019 at 06:08:26PM -0700, Jerry Snitselaar wrote: > On Wed Oct 30 19, Jerry Snitselaar wrote: > > Easily determining what TCG version a tpm device implements > > has been a pain point for userspace for a long time, so > > add a sysfs file to report the TCG major version of a tpm device. > > > > Also add an entry to Documentation/ABI/stable/sysfs-class-tpm > > describing the new file. > > > > Cc: Jarkko Sakkinen > > Cc: Mimi Zohar > > Cc: Peter Huewe > > Cc: Jason Gunthorpe > > Cc: linux-integrity@vger.kernel.org > > Signed-off-by: Jerry Snitselaar > > --- > > v4: - Change file name to tpm_version_major > > - Actually display just the major version. > > - change structs to tpm1_* & tpm2_* > > instead of tpm12_* tpm20_*. > > v3: - Change file name to version_major. > > v2: - Fix TCG usage in commit message. > > - Add entry to sysfs-class-tpm in Documentation/ABI/stable > > > > Documentation/ABI/stable/sysfs-class-tpm | 11 ++++++++ > > drivers/char/tpm/tpm-sysfs.c | 34 +++++++++++++++++++----- > > 2 files changed, 38 insertions(+), 7 deletions(-) > > > > Anyone else have feedback? I can apply this after the issues on hand have been sorted out. /Jarkko