From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1754C2D0C1 for ; Fri, 6 Dec 2019 21:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A29A2467A for ; Fri, 6 Dec 2019 21:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kapsi.fi header.i=@kapsi.fi header.b="MjFQMi7M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbfLFVSn (ORCPT ); Fri, 6 Dec 2019 16:18:43 -0500 Received: from mail.kapsi.fi ([91.232.154.25]:43791 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfLFVSn (ORCPT ); Fri, 6 Dec 2019 16:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YhwINRPF/DR2qVd4V05+XHQkRxdjPjCjqg8j4UAkqdc=; b=MjFQMi7MPcgPJYuyL7OSd5mPBx xWfTQ42QTTHTNNschD6UHeHsSGzxTE1eJeY8z/NY+LbWajpJ3SOQj4NuwuBhgC3fKQYLkxj4sfjNj WOYJg9usOMATDKMiVs1+VbA2aDXCpZfj82Vy8qoKxUG2A+I9D9comFJ68ZfwtqsdNYG365+6WPEBr QaDCtHFR1XCiaUxELCSfRcoqmu/xc/MKQfCQ9BJ3qqMCFedAPl2hZOxQQJ6jCWuwpPoGhT67p6VBq Xz+EDNQJ0xpqwvt9mi+No5FsRQk5HKs9sB3rfItWiWqLek0ec42nSgmArOFkusfVgV+4k97GmlpsJ GNF3rlkA==; Received: from 91-154-92-5.elisa-laajakaista.fi ([91.154.92.5] helo=localhost) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idKzj-0002Bb-LB; Fri, 06 Dec 2019 23:18:35 +0200 Date: Fri, 6 Dec 2019 23:18:34 +0200 From: Jarkko Sakkinen To: Dan Williams , Linus Torvalds , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, James Morris , Stefan Berger , stable Subject: Re: [GIT PULL] tpmdd updates for Linux v5.4 Message-ID: <20191206211834.GD9971@linux.intel.com> References: <20190902143121.pjnykevzlajlcrh6@linux.intel.com> <20191127205800.GA14290@linux.intel.com> <20191127205912.GB14290@linux.intel.com> <20191128012055.f3a6gq7bjpvuierx@cantor> <20191129235322.GB21546@linux.intel.com> <20191130001253.rtovohtfbg25uifm@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191130001253.rtovohtfbg25uifm@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 91.154.92.5 X-SA-Exim-Mail-From: jarkko.sakkinen@linux.intel.com X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, Nov 29, 2019 at 05:12:53PM -0700, Jerry Snitselaar wrote: > On Sat Nov 30 19, Jarkko Sakkinen wrote: > > On Wed, Nov 27, 2019 at 06:20:55PM -0700, Jerry Snitselaar wrote: > > > There also was that other issue reported on the list about > > > tpm_tis_core_init failing when calling tpm_get_timeouts due to the > > > power gating changes. > > > > Please add a (lore.ko) link for reference to this thread. > > > > /Jarkko > > > > https://lore.kernel.org/linux-integrity/a60dadce-3650-44ce-8785-2f737ab9b993@www.fastmail.com/ tpm_chip_stop() probably causes the issue. That is why tpm2_probe() works and failure happens after that. tpm_chip_stop() should be called once at the end of the function. /Jarkko