From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Christian Bundy <christianbundy@fraction.io>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
stable-commits@vger.kernel.org, linux-integrity@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Patch "tpm_tis: reserve chip for duration of tpm_tis_core_init" has been added to the 5.4-stable tree
Date: Mon, 30 Dec 2019 17:33:55 -0700 [thread overview]
Message-ID: <20191231003355.l4zhdingdw5h2ntx@cantor> (raw)
In-Reply-To: <2c4a80e0d30bf1dfe89c6e3469d1dbfb008275fa.camel@linux.intel.com>
On Tue Dec 31 19, Jarkko Sakkinen wrote:
>On Sun, 2019-12-29 at 23:41 -0800, Dan Williams wrote:
>> This looked like the wrong revert to me, and testing confirms that
>> this does not fix the problem.
>>
>> As I mentioned in the original report [1] the commit that bisect flagged was:
>>
>> 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's
>>
>> That commit moved tpm_chip_start() before irq probing. Commit
>> 21df4a8b6018 "tpm_tis: reserve chip for duration of tpm_tis_core_init"
>> does not appear to change anything in that regard.
>>
>> Perhaps this hardware has always had broken interrupts and needs to be
>> quirked off? I'm trying an experiment with tpm_tis_core.interrupts=0
>> workaround.
>>
>>
>> [1]: https://lore.kernel.org/linux-integrity/CAA9_cmeLnHK4y+usQaWo72nUG3RNsripuZnS-koY4XTRC+mwJA@mail.gmail.com/
>
>I think for short term, yes, it is better to revert the commits
>that make things more broken.
>
>for-linus-v5.5-rc5 branch contains three commits that exactly do
>this i.e. the reverts that Stefan sent and revert to Jerry's earlier
>commit.
>
>After that is out of the table it is easier to analyze how the code
>should be actually refactored. Like, I have no idea when I get
>local HW that can reproduce this and Jerry still seems to have the
>same issue. It'd be nice make the exactly right changes instead of
>reverts but situation is what it is.
>
Unfortunately I haven't found a system yet where I get into this code
path. So I've been relying on Dan's testing and the owner of the
t490s.
>Please check the branch and ACK/NAK if I can add tested-by's (and
>other tags).
>
>/Jarkko
>
next prev parent reply other threads:[~2019-12-31 0:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1577122577157232@kroah.com>
2019-12-23 19:46 ` Patch "tpm_tis: reserve chip for duration of tpm_tis_core_init" has been added to the 5.4-stable tree Dan Williams
2019-12-27 6:05 ` Jarkko Sakkinen
2019-12-27 6:11 ` Jarkko Sakkinen
2019-12-28 15:15 ` Jarkko Sakkinen
2019-12-28 17:17 ` Dan Williams
2019-12-30 7:41 ` Dan Williams
2019-12-30 23:28 ` Jarkko Sakkinen
2019-12-31 0:33 ` Jerry Snitselaar [this message]
2019-12-31 1:02 ` Jerry Snitselaar
2019-12-31 16:00 ` Jarkko Sakkinen
2019-12-31 19:47 ` Christian Bundy
2020-01-02 17:20 ` Jarkko Sakkinen
2020-01-02 19:20 ` Dan Williams
2020-01-03 5:04 ` Dan Williams
2020-01-03 22:20 ` Jerry Snitselaar
2020-01-03 22:55 ` Jarkko Sakkinen
2020-01-03 21:51 ` Jarkko Sakkinen
2020-01-03 20:24 ` Jerry Snitselaar
2020-01-03 22:56 ` Jarkko Sakkinen
2020-01-03 23:07 ` Jarkko Sakkinen
2020-01-03 23:30 ` Jarkko Sakkinen
2020-01-03 21:47 ` Jerry Snitselaar
2019-12-31 0:30 ` Jerry Snitselaar
2020-01-01 22:55 ` Dan Williams
2019-12-28 23:39 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231003355.l4zhdingdw5h2ntx@cantor \
--to=jsnitsel@redhat.com \
--cc=christianbundy@fraction.io \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable-commits@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).