From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2 2/2] tpm: tpm2_bios_measurements_next should increase position index
Date: Thu, 6 Feb 2020 00:03:59 +0200 [thread overview]
Message-ID: <20200205220359.GA28111@linux.intel.com> (raw)
In-Reply-To: <3ffb8968-fccc-9f2e-7931-01c634932d5e@virtuozzo.com>
On Mon, Feb 03, 2020 at 08:14:53AM +0300, Vasily Averin wrote:
> On 2/1/20 8:03 PM, Jarkko Sakkinen wrote:
> > On Thu, Jan 30, 2020 at 01:23:21PM +0300, Vasily Averin wrote:
> >> If seq_file .next function does not change position index,
> >> read after non-zero lseek can generate unexpected output.
> >
> > Is it unwanted or unexpected? Unexpected would be mean random
> > output. I don't think that is the case. Please describe more
> > throughly.
>
> If .next function does not change position index,
> following .show function will repeat output related to current position index.
Thank you. That is clear and concise.
Then, please put that to the commit message instead of "unexpected
output".
/Jarkko
next prev parent reply other threads:[~2020-02-05 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 7:48 [PATCH 1/2] tpm1_bios_measurements_next should increase position index Vasily Averin
2020-01-29 13:23 ` Jarkko Sakkinen
2020-01-29 13:25 ` Jarkko Sakkinen
2020-01-30 10:23 ` [PATCH v2 0/2] tpm: seq_file .next functions " Vasily Averin
2020-01-30 10:23 ` [PATCH v2 1/2] tpm: tpm1_bios_measurements_next " Vasily Averin
2020-01-30 10:23 ` [PATCH v2 2/2] tpm: tpm2_bios_measurements_next " Vasily Averin
2020-02-01 17:03 ` Jarkko Sakkinen
2020-02-03 5:14 ` Vasily Averin
2020-02-05 22:03 ` Jarkko Sakkinen [this message]
2020-02-25 6:26 ` [PATCH v3 1/2] tpm: tpm1_bios_measurements_next " Vasily Averin
2020-02-25 10:27 ` Jarkko Sakkinen
2020-02-25 10:29 ` Jarkko Sakkinen
2020-02-25 6:26 ` [PATCH v3 2/2] tpm: tpm2_bios_measurements_next " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205220359.GA28111@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).