From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFBBC11D00 for ; Thu, 20 Feb 2020 22:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF8D4206F4 for ; Thu, 20 Feb 2020 22:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729203AbgBTW0t (ORCPT ); Thu, 20 Feb 2020 17:26:49 -0500 Received: from mga07.intel.com ([134.134.136.100]:17594 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgBTW0t (ORCPT ); Thu, 20 Feb 2020 17:26:49 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 14:26:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,466,1574150400"; d="scan'208";a="315870110" Received: from evieschw-mobl.ger.corp.intel.com (HELO localhost) ([10.251.86.197]) by orsmga001.jf.intel.com with ESMTP; 20 Feb 2020 14:26:39 -0800 Date: Fri, 21 Feb 2020 00:26:38 +0200 From: Jarkko Sakkinen To: Matthew Garrett Cc: linux-integrity , stable@vger.kernel.org Subject: Re: [PATCH V2] tpm: Don't make log failures fatal Message-ID: <20200220222638.GA28411@linux.intel.com> References: <20200102215518.148051-1-matthewgarrett@google.com> <0257b88752b4acdb8715da2fa1c5dfbf9fb1b34b.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Feb 20, 2020 at 12:29:24PM -0800, Matthew Garrett wrote: > On Fri, Jan 3, 2020 at 3:26 PM Jarkko Sakkinen > wrote: > > > > On Thu, 2020-01-02 at 13:55 -0800, Matthew Garrett wrote: > > > If a TPM is in disabled state, it's reasonable for it to have an empty > > > log. Bailing out of probe in this case means that the PPI interface > > > isn't available, so there's no way to then enable the TPM from the OS. > > > In general it seems reasonable to ignore log errors - they shouldn't > > > interfere with any other TPM functionality. > > > > > > Signed-off-by: Matthew Garrett > > > Cc: stable@vger.kernel.org > > > > Reviewed-by: Jarkko Sakkinen > > Hi Jarkko, > > Is this queued anywhere? Thanks! Thanks for reminding. Now is: git://git.infradead.org/users/jjs/linux-tpmdd.git /Jarkko