From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: George Wilson <gcwilson@linux.ibm.com>,
linux-integrity@vger.kernel.org,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Stefan Berger <stefanb@linux.ibm.com>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Linh Pham <phaml@us.ibm.com>
Subject: Re: [PATCH v2] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
Date: Wed, 18 Mar 2020 19:35:42 -0300 [thread overview]
Message-ID: <20200318223542.GD20941@ziepe.ca> (raw)
In-Reply-To: <20200318204318.GA48352@linux.intel.com>
On Wed, Mar 18, 2020 at 10:43:18PM +0200, Jarkko Sakkinen wrote:
> > static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
> >
> > static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> > @@ -147,6 +149,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
> > {
> > struct ibmvtpm_dev *ibmvtpm = dev_get_drvdata(&chip->dev);
> > int rc, sig;
> > + bool retry = true;
>
> Cosmetic: would be nice to have inits when possible in reverse
> Christmas tree order i.e.
>
> struct ibmvtpm_dev *ibmvtpm = dev_get_drvdata(&chip->dev);
> bool retry = true;
> int rc, sig;
>
> It is way more pleasing for the eye when you have to read the source
> code.
I thought only netdev insisted on that :O
Jason
next prev parent reply other threads:[~2020-03-18 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 21:46 [PATCH v2] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send() George Wilson
2020-03-18 20:43 ` Jarkko Sakkinen
2020-03-18 22:35 ` Jason Gunthorpe [this message]
2020-03-19 19:12 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318223542.GD20941@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aik@ozlabs.ru \
--cc=gcwilson@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=phaml@us.ibm.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).