From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Ezra Buehler <ezra@easyb.ch>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org,
Tadeusz Struk <tadeusz.struk@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/tpm2: Change exception handling to be Python 3 compatible
Date: Tue, 14 Apr 2020 19:05:41 +0300 [thread overview]
Message-ID: <20200414160541.GB32775@linux.intel.com> (raw)
In-Reply-To: <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch>
On Tue, Apr 14, 2020 at 01:14:11PM +0200, Ezra Buehler wrote:
> On 14 Apr 2020, at 09:38, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> > OK, I'm aware about the dynamic nature but in this case it is somewhat
> > counter intuitive since it is part of the exception clause. You'd except
> > the Python interpreter to complain.
>
> I agree.
>
> > So, is Flake8 like the standard to be used?
>
> Pretty much, yes. There is also Pylint though. Among other things, they
> both check for PEP 8 (official) coding style compliance.
Thank you for taking time explaining all this. I'll make sure to include
these to my process when I update my test from now on.
/Jarkko
prev parent reply other threads:[~2020-04-14 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:36 [PATCH] selftests/tpm2: Change exception handling to be Python 3 compatible Jarkko Sakkinen
2020-04-12 15:02 ` Ezra Buehler
2020-04-12 17:07 ` Jarkko Sakkinen
2020-04-13 5:02 ` Ezra Buehler
2020-04-13 18:04 ` Jarkko Sakkinen
2020-04-14 5:45 ` Ezra Buehler
2020-04-14 7:38 ` Jarkko Sakkinen
2020-04-14 11:14 ` Ezra Buehler
2020-04-14 16:05 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414160541.GB32775@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ezra@easyb.ch \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).