From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398F4C2BA19 for ; Tue, 14 Apr 2020 16:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EC9D20775 for ; Tue, 14 Apr 2020 16:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391315AbgDNQFs (ORCPT ); Tue, 14 Apr 2020 12:05:48 -0400 Received: from mga14.intel.com ([192.55.52.115]:55287 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390069AbgDNQFp (ORCPT ); Tue, 14 Apr 2020 12:05:45 -0400 IronPort-SDR: kDO3qiueyE/GCw0EtKVR/fyxiZ8px9gEY8yFKyj/8IbvU6au+wRNtXi0cVeNF/uq/4O5yniflf 7YHKnwDNVttw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 09:05:43 -0700 IronPort-SDR: 6IDIkU+SVDccdp2op//SqK8Ae8QZ0bITfXSpXqIGX1hAa1rYsIdE0ltjZfEPNCnBUFJJlPE+7A O2aRXmdOhGPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="298743363" Received: from shiyaowa-mobl.ger.corp.intel.com (HELO localhost) ([10.249.43.105]) by FMSMGA003.fm.intel.com with ESMTP; 14 Apr 2020 09:05:42 -0700 Date: Tue, 14 Apr 2020 19:05:41 +0300 From: Jarkko Sakkinen To: Ezra Buehler Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org, Tadeusz Struk , open list Subject: Re: [PATCH] selftests/tpm2: Change exception handling to be Python 3 compatible Message-ID: <20200414160541.GB32775@linux.intel.com> References: <20200412143656.72955-1-jarkko.sakkinen@linux.intel.com> <1FE03B4F-C42C-4B5F-A4B5-8169705911FA@easyb.ch> <20200412170719.GA324408@linux.intel.com> <531D50E8-E8FC-402E-9226-6000E8B6E960@easyb.ch> <20200413180440.GA10917@linux.intel.com> <20200414073806.GE8403@linux.intel.com> <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Apr 14, 2020 at 01:14:11PM +0200, Ezra Buehler wrote: > On 14 Apr 2020, at 09:38, Jarkko Sakkinen wrote: > > OK, I'm aware about the dynamic nature but in this case it is somewhat > > counter intuitive since it is part of the exception clause. You'd except > > the Python interpreter to complain. > > I agree. > > > So, is Flake8 like the standard to be used? > > Pretty much, yes. There is also Pylint though. Among other things, they > both check for PEP 8 (official) coding style compliance. Thank you for taking time explaining all this. I'll make sure to include these to my process when I update my test from now on. /Jarkko