From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH ima-evm-utils] cmd_ima_bootaggr: Fix for systems without TPM 2.0
Date: Thu, 18 Jun 2020 20:59:26 +0200 [thread overview]
Message-ID: <20200618185926.GB20597@dell5510> (raw)
In-Reply-To: <1592504434.4615.56.camel@linux.ibm.com>
Hi Mimi,
NOTE: this is for systems with TPM 1.2 (not for system without any TPM).
> On Thu, 2020-06-18 at 20:10 +0200, Petr Vorel wrote:
> > For both kernel with and without CONFIG_IMA=y.
> > NOTE: ima_boot_aggregate was added in dc00c92, without TPM 2.0
> > it just reported:
> > EVP_DigestInit() failed
> > (null):
> > Fixes: 917317a ("ima_evm_utils: emit the per TPM PCR bank
> > "boot_aggregate" values")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I don't have a problem with accepting this solution, but I think the
> real problem is that hash_info.h is not included in the kernel-
> headers package on the system. One solution would be to include a
> default hash_info.h file in ima-evm-utils and fall back to using it.
Thanks for a quick answer. I'm not sure if this is a best approach.
But I have /usr/include/linux/hash_info.h on all systems
I tested (4.15 from openSUSE and 5.6.13 on Debian).
Kind regards,
Petr
prev parent reply other threads:[~2020-06-18 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 18:10 [PATCH ima-evm-utils] cmd_ima_bootaggr: Fix for systems without TPM 2.0 Petr Vorel
2020-06-18 18:20 ` Mimi Zohar
2020-06-18 18:59 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618185926.GB20597@dell5510 \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox