From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBF9C433E0 for ; Mon, 6 Jul 2020 23:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A84820723 for ; Mon, 6 Jul 2020 23:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbgGFXBZ (ORCPT ); Mon, 6 Jul 2020 19:01:25 -0400 Received: from mga17.intel.com ([192.55.52.151]:53616 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbgGFXBZ (ORCPT ); Mon, 6 Jul 2020 19:01:25 -0400 IronPort-SDR: NVYg6qBEjCMl/9AnksD1WTDgWxGdYj2ogD+sWTgQhKZmYvAH4IVdr1fqZRZ9OzYJbQQ4IvOv5A /WNRTjh8DBSw== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="127600056" X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="127600056" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 16:01:24 -0700 IronPort-SDR: Ca1lz0TL9DHZXw722DiMo0c1ceiUVKLD/0Jer/zbaAVMGxWB4YsJ2l9NU9t+liKZtHykPUZr6r GyQteUtUapWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="283192674" Received: from hartmaxe-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.53.13]) by orsmga006.jf.intel.com with ESMTP; 06 Jul 2020 16:01:18 -0700 Date: Tue, 7 Jul 2020 02:01:16 +0300 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-integrity@vger.kernel.org, stable@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Sumit Garg , Alexey Klimov , James Bottomley , open list Subject: Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE Message-ID: <20200706230104.GA20770@linux.intel.com> References: <20200702225603.293122-1-jarkko.sakkinen@linux.intel.com> <20200702235544.4o7dbgvlq3br2x7e@cantor> <20200704035615.GA157149@linux.intel.com> <4f93bca3-e5c2-1074-f273-628ed603c139@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f93bca3-e5c2-1074-f273-628ed603c139@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Jul 06, 2020 at 02:06:09PM -0400, Stefan Berger wrote: > On 7/3/20 11:56 PM, Jarkko Sakkinen wrote: > > On Thu, Jul 02, 2020 at 04:55:44PM -0700, Jerry Snitselaar wrote: > > > On Fri Jul 03 20, Jarkko Sakkinen wrote: > > > > The size of the buffers for storing context's and sessions can vary from > > > > arch to arch as PAGE_SIZE can be anything between 4 kB and 256 kB (the > > > > maximum for PPC64). Define a fixed buffer size set to 16 kB. This should be > > > > enough for most use with three handles (that is how many we allow at the > > > > moment). Parametrize the buffer size while doing this, so that it is easier > > > > to revisit this later on if required. > > > > > > > > Reported-by: Stefan Berger > > > > Cc: stable@vger.kernel.org > > > > Fixes: 745b361e989a ("tpm: infrastructure for TPM spaces") > > > > Signed-off-by: Jarkko Sakkinen > > > Reviewed-by: Jerry Snitselaar > > Thank you. > > > > Now only needs tested-by from Stefan. > > > Tested-by: Stefan Berger Thanks. I'll put this eventually to the v5.9 PR. /Jarkko