From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA08C433E0 for ; Thu, 9 Jul 2020 22:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C534C20786 for ; Thu, 9 Jul 2020 22:58:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="rSk5WGGO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgGIW6e (ORCPT ); Thu, 9 Jul 2020 18:58:34 -0400 Received: from linux.microsoft.com ([13.77.154.182]:55292 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgGIW6e (ORCPT ); Thu, 9 Jul 2020 18:58:34 -0400 Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 7CF3B20B4908; Thu, 9 Jul 2020 15:58:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7CF3B20B4908 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1594335513; bh=hSzJx2wtRzs8tVYEA8JZveVIM1/46jY2Nc6LR+6a8eQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rSk5WGGOxrF25+SM75K/PBmOHPatBSoFi5EA1+37GzkrFox6aXG2W26Y4Rlpu8Szf 5yXyDBc3XeLf2DF2jjnRfAGARelF7M2sQA7qCez+gwAoizU4ysAQcEWlaoGkjHGLzo jZk1MKmAQcVBakotL38XMKeFn0+YsOHsbgEn+3SQ= Date: Thu, 9 Jul 2020 17:58:23 -0500 From: Tyler Hicks To: Jarkko Sakkinen Cc: Ard Biesheuvel , Matthew Garrett , Peter Jones , Peter Huewe , Jason Gunthorpe , Petr Vandrovec , Nayna Jain , Thirupathaiah Annapureddy , linux-integrity , linux-efi , Linux Kernel Mailing List Subject: Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures Message-ID: <20200709225823.GA4939@sequoia> References: <20200615232504.1848159-1-tyhicks@linux.microsoft.com> <20200617230958.GC62794@linux.intel.com> <20200630183321.GE4694@sequoia> <20200702235718.GI31291@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702235718.GI31291@linux.intel.com> Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 2020-07-03 02:57:18, Jarkko Sakkinen wrote: > On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote: > > Jarkko, is this an ack from you? > > > > Is there anything I can do to help along this fix? > > > > I've spoke with two others that have poured through these specs to > > implement firmware event log parsers and they thought the change made > > sense. > > > > Tyler > > I revisited the original patch and this stroke into my eye: > > "This is true, for example, when firmware passes the event log to the > kernel via a reserved memory region described in device tree." > > During this discussion you gave an explanation what can trigger the bug > but in the commit message nothing anchors to anything. > > Please give a concrete example what can trigger the issue directly in > the commit message instead. It's obviously needed. > > In addition, you could also rewrite the existing inline comment to be > something more reasonable to the context. These are all fair points and I also see that there's a new conflict with the TPM next branch. I'll rebase the patch on the current next branch, expand on the commit message, and improve the comment in v2. Tyler > > /Jarkko