From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Cyril Hrubis <chrubis@suse.cz>
Subject: Re: [PATCH ima-evm-utils v2] Check for tsspcrread in runtime
Date: Thu, 16 Jul 2020 10:15:38 +0200 [thread overview]
Message-ID: <20200716081538.GC18117@dell5510> (raw)
In-Reply-To: <1594841666.12900.335.camel@linux.ibm.com>
> On Wed, 2020-07-15 at 15:37 +0200, Petr Vorel wrote:
> > Hi Mimi,
> > > instead of checking in build time as it's runtime dependency.
> > > Also log when tsspcrread not found to make debugging easier.
> > > We search for tsspcrread unless there is tss2-esys with Esys_PCR_Read(),
> > > thus pcr_none.c was dropped as unneeded.
> > > file_exist(), tst_get_path() and MIN() taken from LTP project.
> > BTW these parts holds Cyril's copyright. If you ever add copyright to
> > src/utils.[ch], please add it there.
> > Copyright (C) 2010 Cyril Hrubis <chrubis@suse.cz>
> Are you Ok with the following?
Yes, thanks!
Kind regards,
Petr
> diff --git a/src/utils.c b/src/utils.c
> index 416a88c6dbe4..a6ae08fa4d84 100644
> --- a/src/utils.c
> +++ b/src/utils.c
> @@ -1,3 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * utils: set of common functions
> + *
> + * Copyright (C) 2020 Vitaly Chikunov <vt@altlinux.org>
> + * Copyright (C) 2010 Cyril Hrubis <chrubis@suse.cz>
> + */
> #include <stdint.h>
> #include <stdio.h>
> #include <stdlib.h>
> Mimi
next prev parent reply other threads:[~2020-07-16 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 13:28 [PATCH ima-evm-utils v2] Check for tsspcrread in runtime Petr Vorel
2020-07-15 13:37 ` Petr Vorel
2020-07-15 19:34 ` Mimi Zohar
2020-07-15 19:57 ` Vitaly Chikunov
2020-07-15 20:02 ` Mimi Zohar
2020-07-16 8:15 ` Petr Vorel [this message]
2020-07-16 1:47 ` Mimi Zohar
2020-07-16 8:07 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716081538.GC18117@dell5510 \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox