From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH ima-evm-utils] Add sanity check for file parameter of ima_boot_aggregate
Date: Mon, 20 Jul 2020 10:00:37 +0200 [thread overview]
Message-ID: <20200720080037.GB8754@dell5510> (raw)
In-Reply-To: <1595167054.27397.72.camel@linux.ibm.com>
Hi Mimi,
...
> Thanks! I made minor changes as noted below. A subsequent patch
> makes a similar change for the new TPM 1.2 PCRs.
+1 to all the changes. I guess you haven't pushed it yet.
Kind regards,
Petr
> > src/evmctl.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> > diff --git a/src/evmctl.c b/src/evmctl.c
> > index 04dc2ad..3ad5039 100644
> > --- a/src/evmctl.c
> > +++ b/src/evmctl.c
> > @@ -2082,6 +2082,13 @@ static int read_binary_bios_measurements(char *file, struct tpm_bank_info *bank)
> > int len;
> > int i;
> > + struct stat s;
> > + stat(file, &s);
> Checked stat return code.
> > + if (!S_ISREG(s.st_mode)) {
> > + log_errno("Not a regular file or link to regular file.\n");
> Prefixed message with "Bios event log: not ..."
...
next prev parent reply other threads:[~2020-07-20 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 12:04 [PATCH ima-evm-utils] Add sanity check for file parameter of ima_boot_aggregate Petr Vorel
2020-07-19 13:57 ` Mimi Zohar
2020-07-20 8:00 ` Petr Vorel [this message]
2020-07-20 11:48 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720080037.GB8754@dell5510 \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).