From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CB6C433E4 for ; Mon, 20 Jul 2020 08:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECDF422482 for ; Mon, 20 Jul 2020 08:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbgGTIdc (ORCPT ); Mon, 20 Jul 2020 04:33:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:60952 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgGTIdc (ORCPT ); Mon, 20 Jul 2020 04:33:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 92C28AE0D; Mon, 20 Jul 2020 08:33:37 +0000 (UTC) Date: Mon, 20 Jul 2020 10:33:30 +0200 From: Petr Vorel To: Mimi Zohar Cc: linux-integrity@vger.kernel.org, Bruno Meneguele Subject: Re: [PATCH 2/3] ima-evm-utils: output specific "unknown keyid" file msg based on log level Message-ID: <20200720083330.GD11397@dell5510> Reply-To: Petr Vorel References: <1595174524-4976-1-git-send-email-zohar@linux.ibm.com> <1595174524-4976-2-git-send-email-zohar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1595174524-4976-2-git-send-email-zohar@linux.ibm.com> Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Mimi, > - log_info("%s: verification failed: unknown keyid %x\n", > - file, __be32_to_cpup(&keyid)); > + if (imaevm_params.verbose > LOG_INFO) > + log_info("%s: verification failed: unknown keyid %x\n", BTW, I was thinking to add more macros which would handle if (imaevm_params.verbose > LOG_INFO), something like: +#define log_dump_verbose(p, len) if (imaevm_params.verbose > LOG_INFO) do_dump(p, len, true) +#define log_verbose(fmt, args...) if (imaevm_params.verbose > LOG_INFO) log_info(fmt, ##args) But in the end I didn't post it, because: 1) imaevm_params.verbose is sometimes used for other purpose: src/evmctl.c: if (sigdump || imaevm_params.verbose >= LOG_INFO) imaevm_hexdump(sig, len); ... if (imaevm_params.verbose > LOG_INFO) { log_info("%d ", entry->header.pcr); log_dump_n(entry->header.digest, sizeof(entry->header.digest)); log_info(" %s %s", entry->name, algo); log_dump_n(digest, digest_len); log_info(" %s", path); if (fbuf) { log_info(" "); log_dump_n(fbuf, fbuf_len); } } ... if (imaevm_params.verbose <= LOG_INFO) return; 2) code sometimes compares: imaevm_params.verbose >= LOG_INFO (i.e. >= vs >; is that intentional?) Kind regards, Petr