From: Petr Vorel <pvorel@suse.cz>
To: Lachlan Sneff <t-josne@linux.microsoft.com>
Cc: zohar@linux.ibm.com, ltp@lists.linux.it,
nramas@linux.microsoft.com, balajib@linux.microsoft.com,
linux-integrity@vger.kernel.org, tyhicks@linux.microsoft.com,
yaneurabeya@gmail.com, zhang.jia@linux.alibaba.com
Subject: Re: [PATCH 2/3] IMA: Refactor datafiles directory
Date: Fri, 7 Aug 2020 14:27:23 +0200 [thread overview]
Message-ID: <20200807122723.GB11014@dell5510> (raw)
In-Reply-To: <20200807090147.GB21400@dell5510>
Hi Lachlan,
> > > The IMA datafiles directory is structured so that it cannot be directly
> > > expanded to include datafiles for tests other than `ima_policy.sh`.
> > > Move the contents of the IMA datafiles directory into an IMA
> > > datafiles/policy directory.
> > Why it's required? Can't you use glob for inclusion?
> > *.policy for valid policies
> > *.policy-invalid for invalid policies
> > *.policy* for all policies
> > BTW I plan to use policies for other tests than just ima_policy.sh
> > I don't refuse this patch, I just simply don't understand why it's required.
> OK, I got that. Looking into $TST_DATAROOT is self explanatory.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> And I plan to use IMA policy as well for more tests will require some trick,
> but that's another story.
Thinking about it twice, keycheck.policy and kexec.policy should not be in
/opt/ltp/testcases/data/ima_policy/ as they belong to the their tests
(ima_keys.sh resp. ima_kexec.sh). I forget where are installed due "policy"
(the name of the directory).
I'll send v2 (altogether with fixes for the test) to speedup the things.
Kind regards,
Petr
next prev parent reply other threads:[~2020-08-07 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 18:47 [PATCH v1 0/3] Verify measurement of certificate imported into a keyring Lachlan Sneff
2020-08-03 18:47 ` [PATCH 1/3] IMA: Update key test documentation Lachlan Sneff
2020-08-04 4:35 ` Petr Vorel
2020-08-04 16:42 ` Lachlan Sneff
2020-08-05 8:36 ` Petr Vorel
2020-08-05 8:44 ` Petr Vorel
2020-08-03 18:47 ` [PATCH 2/3] IMA: Refactor datafiles directory Lachlan Sneff
2020-08-07 7:17 ` Petr Vorel
2020-08-07 9:01 ` Petr Vorel
2020-08-07 12:27 ` Petr Vorel [this message]
2020-08-03 18:47 ` [PATCH 3/3] IMA: Add a test to verify measurement of certificate imported into a keyring Lachlan Sneff
-- strict thread matches above, loose matches on Subject: below --
2020-08-03 17:59 [PATCH v1 0/3] Verify " Lachlan Sneff
2020-08-03 17:59 ` [PATCH 2/3] IMA: Refactor datafiles directory Lachlan Sneff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807122723.GB11014@dell5510 \
--to=pvorel@suse.cz \
--cc=balajib@linux.microsoft.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=nramas@linux.microsoft.com \
--cc=t-josne@linux.microsoft.com \
--cc=tyhicks@linux.microsoft.com \
--cc=yaneurabeya@gmail.com \
--cc=zhang.jia@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox