From: Jason Gunthorpe <jgg@ziepe.ca>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH] tpm_tis: Add a check for invalid status
Date: Mon, 28 Sep 2020 15:33:51 -0300 [thread overview]
Message-ID: <20200928183351.GA587339@ziepe.ca> (raw)
In-Reply-To: <9bad3da0c31ae2620aaae0d75748c3387afa3d47.camel@HansenPartnership.com>
On Mon, Sep 28, 2020 at 11:00:12AM -0700, James Bottomley wrote:
> Some TIS based TPMs can return 0xff to status reads if the locality
> hasn't been properly requested. Detect this condition by checking the
> bits that the TIS spec specifies must return zero are clear and return
> zero in that case. Also drop a warning so the problem can be
> identified in the calling path and fixed (usually a missing
> try_get_ops()).
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> This is the patch I've been using to catch and kill all the points in
> the stack where we're not properly using get/put ops on the tpm chip.
If this is a problem add a lockdep on ops_sem in various places too?
Jason
next prev parent reply other threads:[~2020-09-28 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 18:00 [PATCH] tpm_tis: Add a check for invalid status James Bottomley
2020-09-28 18:33 ` Jason Gunthorpe [this message]
2020-09-28 21:15 ` James Bottomley
2020-09-30 1:37 ` Jarkko Sakkinen
2020-09-30 1:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928183351.GA587339@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).