From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of PCR registers
Date: Fri, 4 Dec 2020 06:55:45 +0200 [thread overview]
Message-ID: <20201204045545.GF84413@linux.intel.com> (raw)
In-Reply-To: <20201129223022.5153-2-James.Bottomley@HansenPartnership.com>
On Sun, Nov 29, 2020 at 02:30:22PM -0800, James Bottomley wrote:
> + default:
> + /*
> + * If this warning triggers, send a patch to
> + * add both a PCR_ATTR_BUILD() macro above for
> + * the missing algorithm as well as an
> + * additional case in this switch statement.
> + */
> + WARN(1, "TPM with unsupported bank algorthm 0x%04x",
> + chip->allocated_banks[i].alg_id);
Please use pr_info() here instead. We don't want to dump the stack
because of this. Nothing is working as far as kernel goes in an
unexpected manner.
/Jarkko
next prev parent reply other threads:[~2020-12-04 4:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 22:30 [PATCH RESEND v4 0/1] add sysfs exports for TPM 2 PCR registers James Bottomley
2020-11-29 22:30 ` [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-11-30 8:17 ` Greg KH
2020-11-30 19:00 ` Elliott, Robert (Servers)
2020-11-30 19:53 ` James Bottomley
2020-11-30 22:50 ` Elliott, Robert (Servers)
2020-11-30 22:57 ` James Bottomley
2020-12-23 15:58 ` Ken Goldman
2020-12-04 4:55 ` Jarkko Sakkinen [this message]
2020-11-30 8:18 ` [PATCH RESEND v4 0/1] add sysfs exports for TPM 2 " Greg KH
2020-11-30 15:21 ` Mimi Zohar
2020-11-30 15:26 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2020-09-06 20:32 James Bottomley
2020-09-06 20:32 ` [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-09-07 5:39 ` Greg KH
2020-09-07 5:59 ` James Bottomley
2020-09-07 13:21 ` Jarkko Sakkinen
2020-09-07 17:37 ` Greg KH
2020-09-08 17:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204045545.GF84413@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).