From: Jarkko Sakkinen <jarkko@kernel.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] char/tpm: simplify the return expression of tpm_tis_synquacer_module_init()
Date: Fri, 11 Dec 2020 12:53:34 +0200 [thread overview]
Message-ID: <20201211105334.GG12091@kernel.org> (raw)
In-Reply-To: <20201210135515.1310-1-zhengyongjun3@huawei.com>
On Thu, Dec 10, 2020 at 09:55:15PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
I don't see how this would be meaningful change as the existing
code is according to the coding style.
> ---
> drivers/char/tpm/tpm_tis_synquacer.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
> index e47bdd272704..3b4ae2f23f09 100644
> --- a/drivers/char/tpm/tpm_tis_synquacer.c
> +++ b/drivers/char/tpm/tpm_tis_synquacer.c
> @@ -188,13 +188,8 @@ static struct platform_driver tis_synquacer_drv = {
>
> static int __init tpm_tis_synquacer_module_init(void)
> {
> - int rc;
>
> - rc = platform_driver_register(&tis_synquacer_drv);
> - if (rc)
> - return rc;
> -
> - return 0;
> + return platform_driver_register(&tis_synquacer_drv);
> }
>
> static void __exit tpm_tis_synquacer_module_exit(void)
> --
> 2.22.0
>
>
/Jarkko
prev parent reply other threads:[~2020-12-11 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 13:55 [PATCH -next] char/tpm: simplify the return expression of tpm_tis_synquacer_module_init() Zheng Yongjun
2020-12-11 10:53 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211105334.GG12091@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).