From: Dirk Gouders <dirk@gouders.net>
To: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: Dirk Gouders <dirk@gouders.net>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()
Date: Fri, 5 Feb 2021 21:20:21 +0100 [thread overview]
Message-ID: <20210205202022.4515-1-dirk@gouders.net> (raw)
Hello,
I noticed that the tpm_tis driver behaves different depending on
wether it was compiled builtin or as a module.
At least on my hardware, if builtin it always falls back to polling mode
without notification which I do not understand considering the current
efforts to fix interrupt probing[1].
The builtin case could be fixed by handling -EPROBE_DEFER. With a
temporary dev_dbg() call added and James Bottomley's
"[PATCH v2 4/5] tpm_tis: fix IRQ probing [1]" applied my kernel log
looks like this:
[ 2.671629] tpm_tis STM0125:00: Waiting for interrupt...
[ 2.851920] tpm_tis STM0125:00: Waiting for interrupt...
[ 2.852627] tpm_tis STM0125:00: Waiting for interrupt...
[ 2.908286] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.340223] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.407238] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.408178] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.408994] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.487694] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.773769] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.868590] tpm_tis STM0125:00: Waiting for interrupt...
[ 3.923855] tpm_tis STM0125:00: Waiting for interrupt...
[ 4.235670] tpm_tis STM0125:00: Waiting for interrupt...
[ 4.852556] tpm_tis STM0125:00: Waiting for interrupt...
[ 6.767544] tpm_tis STM0125:00: 2.0 TPM (device-id 0x0, rev-id 78)
[ 6.767567] tpm_tis STM0125:00: TPM interface capabilities (0x30000415):
[ 6.767569] tpm_tis STM0125:00: Interrupt Level Low
[ 6.767570] tpm_tis STM0125:00: Locality Change Int Support
[ 6.767570] tpm_tis STM0125:00: Data Avail Int Support
Of course, this patch should not be added before Jarkko's fix [2], because
builtin drivers would then hit the WARN_ONCE(), as well.
Dirk
[1] https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
[2] https://lore.kernel.org/linux-integrity/3936843b-c0da-dd8c-8aa9-90aa3b49d525@linux.ibm.com/T/#t
Dirk Gouders (1):
tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()
drivers/char/tpm/tpm_tis.c | 3 +++
1 file changed, 3 insertions(+)
--
2.26.2
next reply other threads:[~2021-02-05 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 20:20 Dirk Gouders [this message]
2021-02-05 20:20 ` [PATCH 1/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe() Dirk Gouders
2021-02-08 0:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205202022.4515-1-dirk@gouders.net \
--to=dirk@gouders.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).