From: Jarkko Sakkinen <jarkko@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: stable@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Greg KH <greg@kroah.com>, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: Replace WARN_ONCE() with dev_err_once() in tpm_tis_status()
Date: Tue, 1 Jun 2021 20:36:57 +0300 [thread overview]
Message-ID: <20210601173657.4bgqj2ndvryzrbzo@kernel.org> (raw)
In-Reply-To: <bbd2c61c-edd7-f830-aafe-2881ba7d2614@molgen.mpg.de>
On Mon, May 31, 2021 at 07:33:44AM +0200, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Am 31.05.21 um 06:51 schrieb Jarkko Sakkinen:
> > Do not torn down the system when getting invalid status from a TPM chip.
>
> Nit: Do not *tear* down …?
Oops, a typo, thank you.
> > This can happen when panic-on-warn is used.
>
> Hmm, I’d say it works as expected then? Shouldn’t an invalid status of an
> important device like TPM considered a warning?
By warning do you mean WARN() or pr_warn()?
/Jarkko
prev parent reply other threads:[~2021-06-01 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 4:51 [PATCH] tpm: Replace WARN_ONCE() with dev_err_once() in tpm_tis_status() Jarkko Sakkinen
2021-05-31 5:14 ` Greg KH
2021-05-31 5:33 ` Paul Menzel
2021-06-01 17:36 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601173657.4bgqj2ndvryzrbzo@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=greg@kroah.com \
--cc=hdegoede@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox