Re: [PATCH 1/2] Fix sign_hash not observing the hashalgo argument

Vitaly Chikunov
2021-01-07T13:09:00Z

Patrick, Mimi,

On Thu, Jan 07, 2021 at 07:24:43AM -0500, Mimi Zohar wrote:
> On Wed, 2021-01-06 at 10:43 +0100, Patrick Uiterwijk wrote:
> > This fixes sign_hash not using the correct algorithm for creating the
> > signature, by ensuring it uses the passed in variable value.
> >
> > Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
>
> Thank you. This is a regression first introduced in commit
> 07e623b60848 ("ima-evm-utils: Convert sign_hash_v2 to EVP_PKEY API").

Ah, when sign_hash() is used not via evmctl, but as a library
imaevm_params may be not set.

Thanks!