From: Christian Brauner <christian.brauner@ubuntu.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: jejb@linux.ibm.com, linux-integrity@vger.kernel.org,
zohar@linux.ibm.com, serge@hallyn.com,
containers@lists.linux.dev, dmitry.kasatkin@gmail.com,
ebiederm@xmission.com, krzysztof.struczynski@huawei.com,
roberto.sassu@huawei.com, mpeters@redhat.com, lhinds@redhat.com,
lsturman@redhat.com, puiterwi@redhat.com, jamjoom@us.ibm.com,
linux-kernel@vger.kernel.org, paul@paul-moore.com,
rgb@redhat.com, linux-security-module@vger.kernel.org,
jmorris@namei.org
Subject: Re: [RFC v2 19/19] ima: Setup securityfs for IMA namespace
Date: Mon, 6 Dec 2021 12:52:20 +0100 [thread overview]
Message-ID: <20211206115220.7ku74xddmmlhbjdh@wittgenstein> (raw)
In-Reply-To: <b285b0d4-e615-bea4-f22f-09d83f8f8edb@linux.ibm.com>
On Fri, Dec 03, 2021 at 07:33:39PM -0500, Stefan Berger wrote:
>
> On 12/3/21 14:11, Stefan Berger wrote:
> >
> > On 12/3/21 13:50, James Bottomley wrote:
> >
> >
> > >
> > > > Where would the vfsmount pointer reside? For now it's in
> > > > ima_namespace, but it sounds like it should be in a more centralized
> > > > place? Should it also be connected to the user_namespace so we can
> > > > pick it up using get_user_ns()?
> > > exactly. I think struct user_namespace should have two elements gated
> > > by a #ifdef CONFIG_SECURITYFS which are the vfsmount and the
> > > mount_count for passing into simple_pin_fs.
> >
> > Also that we can do for as long as it flies beyond the conversation
> > here... :-) Anyone else have an opinion ?
>
> I moved it now and this greatly reduced the amount of changes. The dentries
> are now all in the ima_namespace and it works with one API. Thanks!
Ideally you only have one entry in struct user_namespace for ima that
encompasses all information needed; not multiple entries. Similar to
what I did for binfmt_misc
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fs.binfmt_misc&id=eb50eb90a694e05f6fd6533951a56ca3ed040761
if that works.
next prev parent reply other threads:[~2021-12-06 11:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 2:30 [RFC v2 00/19] ima: Namespace IMA with audit support in IMA-ns Stefan Berger
2021-12-03 2:31 ` [RFC v2 01/19] ima: Add IMA namespace support Stefan Berger
2021-12-03 2:31 ` [RFC v2 02/19] ima: Define ns_status for storing namespaced iint data Stefan Berger
2021-12-03 2:31 ` [RFC v2 03/19] ima: Namespace audit status flags Stefan Berger
2021-12-03 2:31 ` [RFC v2 04/19] ima: Move delayed work queue and variables into ima_namespace Stefan Berger
2021-12-03 2:31 ` [RFC v2 05/19] ima: Move IMA's keys queue related " Stefan Berger
2021-12-03 2:31 ` [RFC v2 06/19] ima: Move policy " Stefan Berger
2021-12-03 2:31 ` [RFC v2 07/19] ima: Move ima_htable " Stefan Berger
2021-12-03 2:31 ` [RFC v2 08/19] ima: Move measurement list related variables " Stefan Berger
2021-12-03 2:31 ` [RFC v2 09/19] ima: Only accept AUDIT rules for IMA non-init_ima_ns namespaces for now Stefan Berger
2021-12-03 2:31 ` [RFC v2 10/19] ima: Implement hierarchical processing of file accesses Stefan Berger
2021-12-03 2:31 ` [RFC v2 11/19] securityfs: Prefix global variables with securityfs_ Stefan Berger
2021-12-03 2:31 ` [RFC v2 12/19] securityfs: Pass static variables as parameters from top level functions Stefan Berger
2021-12-03 2:31 ` [RFC v2 13/19] securityfs: Extend securityfs with namespacing support Stefan Berger
2021-12-03 2:31 ` [RFC v2 14/19] ima: Move some IMA policy and filesystem related variables into ima_namespace Stefan Berger
2021-12-03 2:31 ` [RFC v2 15/19] capabilities: Introduce CAP_INTEGRITY_ADMIN Stefan Berger
2021-12-03 16:40 ` Casey Schaufler
2021-12-03 17:39 ` Stefan Berger
2021-12-03 2:31 ` [RFC v2 16/19] ima: Use integrity_admin_ns_capable() to check corresponding capability Stefan Berger
2021-12-03 2:31 ` [RFC v2 17/19] userns: Introduce a refcount variable for calling early teardown function Stefan Berger
2021-12-03 2:31 ` [RFC v2 18/19] ima/userns: Define early teardown function for IMA namespace Stefan Berger
2021-12-03 2:31 ` [RFC v2 19/19] ima: Setup securityfs " Stefan Berger
2021-12-03 15:07 ` Stefan Berger
2021-12-03 17:03 ` James Bottomley
2021-12-03 18:06 ` Stefan Berger
2021-12-03 18:50 ` James Bottomley
2021-12-03 19:11 ` Stefan Berger
2021-12-04 0:33 ` Stefan Berger
2021-12-06 11:52 ` Christian Brauner [this message]
2021-12-06 4:27 ` James Bottomley
2021-12-06 14:03 ` Stefan Berger
2021-12-06 14:11 ` James Bottomley
2021-12-06 17:22 ` Stefan Berger
2021-12-03 19:37 ` Casey Schaufler
2021-12-06 12:08 ` Christian Brauner
2021-12-06 13:38 ` James Bottomley
2021-12-06 14:13 ` Christian Brauner
2021-12-06 15:44 ` Christian Brauner
2021-12-06 16:25 ` James Bottomley
2021-12-06 14:11 ` Christian Brauner
2021-12-06 14:21 ` James Bottomley
2021-12-06 14:42 ` Christian Brauner
2021-12-06 14:51 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206115220.7ku74xddmmlhbjdh@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=containers@lists.linux.dev \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jamjoom@us.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=krzysztof.struczynski@huawei.com \
--cc=lhinds@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lsturman@redhat.com \
--cc=mpeters@redhat.com \
--cc=paul@paul-moore.com \
--cc=puiterwi@redhat.com \
--cc=rgb@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox