From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF52EC433F5 for ; Sun, 10 Apr 2022 17:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236687AbiDJR2F (ORCPT ); Sun, 10 Apr 2022 13:28:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233236AbiDJR2F (ORCPT ); Sun, 10 Apr 2022 13:28:05 -0400 X-Greylist: delayed 443 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 10 Apr 2022 10:25:54 PDT Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87F3460D8C; Sun, 10 Apr 2022 10:25:54 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id C1C9F2800A278; Sun, 10 Apr 2022 19:18:26 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id B5498324E0; Sun, 10 Apr 2022 19:18:26 +0200 (CEST) Date: Sun, 10 Apr 2022 19:18:26 +0200 From: Lukas Wunner To: Lino Sanfilippo Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, =robh+dt@kernel.org, devicetree@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, stefanb@linux.ibm.com, p.rosenberger@kunbus.com Subject: Re: [PATCH 5/5] tpm: tpm_tis_spi_slb_9670: implement set_reset and unset_reset functions Message-ID: <20220410171826.GB24453@wunner.de> References: <20220407111849.5676-1-LinoSanfilippo@gmx.de> <20220407111849.5676-6-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407111849.5676-6-LinoSanfilippo@gmx.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Apr 07, 2022 at 01:18:49PM +0200, Lino Sanfilippo wrote: > --- /dev/null > +++ b/drivers/char/tpm/tpm_tis_spi_slb9670.c [...] > +int slb9670_spi_unset_reset(struct tpm_tis_data *data) [...] > +int slb9670_spi_set_reset(struct tpm_tis_data *data) [...] > +static const struct tpm_tis_phy_ops slb9670_spi_phy_ops = { > + .read_bytes = tpm_tis_spi_read_bytes, > + .write_bytes = tpm_tis_spi_write_bytes, > + .read16 = tpm_tis_spi_read16, > + .read32 = tpm_tis_spi_read32, > + .write32 = tpm_tis_spi_write32, > + .set_reset = slb9670_spi_set_reset, > + .unset_reset = slb9670_spi_unset_reset, > +}; 0-day is complaining that slb9670_spi_set_reset() / slb9670_spi_unset_reset() are not declared static: https://lore.kernel.org/all/202204081357.8SfjQosI-lkp@intel.com/ Thanks, Lukas