From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F253C19F2B for ; Mon, 1 Aug 2022 13:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbiHAN5d (ORCPT ); Mon, 1 Aug 2022 09:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbiHAN51 (ORCPT ); Mon, 1 Aug 2022 09:57:27 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3BC25C5D; Mon, 1 Aug 2022 06:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1659362243; x=1690898243; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tmyZ8VzcKme1sHdR4I9onW+CMH1hI941TrHRwHUZX5k=; b=YKL7TJL4NsGbBxQn8ofmpGM5DSekl/C8k68djStBkb0SFqfVsrCdavQH RCBgWQYP3GhRWNA7zRGf4LgrniIM5jHc01qHD24CP2V2Syw5uSiWq/Nz2 RKA0FQoL7X4cz5OqsXAqK+B3O8wWIZDJlIbSSq/amCgzA/9jVqtsAJY44 8SSalKmadbtDX4d/13nAvsRchqPF2HS8sLUOOzXstmTSKP4YHj4WoxXoQ 6BahD5/ZYk0Hhd5GnQtdOWLDvp4KU3H+2kvrU1wcT91QCARtEq2q5j8pk I4/2P1AMxhs++GXS1pwOP3uF0FtirTh6FXfDw1r/SV/pmCfKYRxQdOlWZ Q==; From: =?UTF-8?q?M=C3=A5rten=20Lindahl?= To: Peter Huewe , Jarkko Sakkinen CC: Jason Gunthorpe , , , =?UTF-8?q?M=C3=A5rten=20Lindahl?= , Subject: [PATCH v4] tpm: Add check for Failure mode for TPM2 modules Date: Mon, 1 Aug 2022 15:57:03 +0200 Message-ID: <20220801135703.26754-1-marten.lindahl@axis.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org In commit 0aa698787aa2 ("tpm: Add Upgrade/Reduced mode support for TPM2 modules") it was said that: "If the TPM is in Failure mode, it will successfully respond to both tpm2_do_selftest() and tpm2_startup() calls. Although, will fail to answer to tpm2_get_cc_attrs_tbl(). Use this fact to conclude that TPM is in Failure mode." But a check was never added in the commit when calling tpm2_get_cc_attrs_tbl() to conclude that the TPM is in Failure mode. This commit corrects this by adding a check. Fixes: 0aa698787aa2 ("tpm: Add Upgrade/Reduced mode support for TPM2 modules") Cc: stable@vger.kernel.org # v5.17+ Signed-off-by: Mårten Lindahl Reviewed-by: Jarkko Sakkinen --- v4: - Resend of patch because of invalid characters in Signed-off-by tag. v3: - Add Jarkkos Reviewed-by tag. - Add Fixes tag and Cc. v2: - Add missed check for TPM error code. drivers/char/tpm/tpm2-cmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c index c1eb5d223839..65d03867e114 100644 --- a/drivers/char/tpm/tpm2-cmd.c +++ b/drivers/char/tpm/tpm2-cmd.c @@ -752,6 +752,12 @@ int tpm2_auto_startup(struct tpm_chip *chip) } rc = tpm2_get_cc_attrs_tbl(chip); + if (rc == TPM2_RC_FAILURE || (rc < 0 && rc != -ENOMEM)) { + dev_info(&chip->dev, + "TPM in field failure mode, requires firmware upgrade\n"); + chip->flags |= TPM_CHIP_FLAG_FIRMWARE_UPGRADE; + rc = 0; + } out: /* -- 2.30.2