From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDE7C4332F for ; Fri, 4 Nov 2022 18:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232145AbiKDSei (ORCPT ); Fri, 4 Nov 2022 14:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbiKDSeg (ORCPT ); Fri, 4 Nov 2022 14:34:36 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F32F640919 for ; Fri, 4 Nov 2022 11:34:32 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id q9so5235974pfg.5 for ; Fri, 04 Nov 2022 11:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fFlgEoQ+2ARPKvzYCLdvHvwC3pq/RnzvVojet0DXLgg=; b=nJ8Xa/ROHn8AT1PIg/dhjRMINqphLAL/bOrhvxGaJRCtDh1l/knL1nNHyUgybie2+i 4/4cKvfd0kb4xC00W02DHqwHRJlnuzWSqU376vzNvl9FZx33yev9vWF/3XjSBccf27dl Emj5vMOkiP2lYyhiVng01hYuCLd3maODPa/LI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fFlgEoQ+2ARPKvzYCLdvHvwC3pq/RnzvVojet0DXLgg=; b=GZ2aRT5yTfs1AcoEKtaL4RZ0urafTI4sBqduJe9D/5t6XAFXJzelxv5n4NvcMc5UfD +3Z18rRsL2bTDFHGo5FNhf0n7v3jnxO24ifu51SzKPrSHVf+zoCeLGAjwqqRZdO2wUXs sBIie+gmg48X1MKdIozztAbZBieXjvxjq3P/gFNMgAartvtclqwLr6GwqeOYP1gjeZ6I Pkybx2ogy4EpbzTFRC0jtvaRbQ5KyYT2ms9W2j9zhMuTYqLbteMTYcRrADRrc4B6h67n W5KlrAwOML8EyjkuQu9if1w+Qf6DbEkDmkLyxwd7XoBYON5RnhyAd2/qX+IOZcFQca+0 NMIg== X-Gm-Message-State: ACrzQf29Ejtyq04RdolbVc4T/Pqc9cfPimB3ArcQNv9yEtA5u6OLFswN vLy6HQazeIi2DfF/IdWClZj2uVxZL5y9zA== X-Google-Smtp-Source: AMsMyM6S7zxtJ4UwzgqjmSKGYJg8U3NwTZne4WYB2avbtJ8sShe6lVSGKAHshLFa5m0rqJszHDmCRw== X-Received: by 2002:a63:1206:0:b0:470:18c:1489 with SMTP id h6-20020a631206000000b00470018c1489mr14766650pgl.357.1667586872547; Fri, 04 Nov 2022 11:34:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b9-20020aa79509000000b0056bc30e618dsm3071068pfp.38.2022.11.04.11.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 11:34:32 -0700 (PDT) Date: Fri, 4 Nov 2022 11:34:31 -0700 From: Kees Cook To: Evan Green Cc: linux-kernel@vger.kernel.org, corbet@lwn.net, linux-pm@vger.kernel.org, rjw@rjwysocki.net, gwendal@chromium.org, apronin@chromium.org, Pavel Machek , Matthew Garrett , linux-integrity@vger.kernel.org, jejb@linux.ibm.com, zohar@linux.ibm.com, dlunev@google.com, Eric Biggers , Ben Boeckel , jarkko@kernel.org, Matthew Garrett , Matthew Garrett , Ben Boeckel , David Howells , James Morris , Paul Moore , "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-doc@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v4 05/11] security: keys: trusted: Allow storage of PCR values in creation data Message-ID: <202211041134.927C258@keescook> References: <20221103180120.752659-1-evgreen@chromium.org> <20221103105558.v4.5.I32591db064b6cdc91850d777f363c9d05c985b39@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103105558.v4.5.I32591db064b6cdc91850d777f363c9d05c985b39@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Nov 03, 2022 at 11:01:13AM -0700, Evan Green wrote: > From: Matthew Garrett > > When TPMs generate keys, they can also generate some information > describing the state of the PCRs at creation time. This data can then > later be certified by the TPM, allowing verification of the PCR values. > This allows us to determine the state of the system at the time a key > was generated. Add an additional argument to the trusted key creation > options, allowing the user to provide the set of PCRs that should have > their values incorporated into the creation data. > > Link: https://lore.kernel.org/lkml/20210220013255.1083202-6-matthewgarrett@google.com/ > Signed-off-by: Matthew Garrett Reviewed-by: Kees Cook -- Kees Cook