From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51248C4332F for ; Fri, 4 Nov 2022 18:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232176AbiKDSjC (ORCPT ); Fri, 4 Nov 2022 14:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232119AbiKDSjA (ORCPT ); Fri, 4 Nov 2022 14:39:00 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5481E1D0CF for ; Fri, 4 Nov 2022 11:38:58 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d20so4612372plr.10 for ; Fri, 04 Nov 2022 11:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GxUQcGD1ekL/2d9GXVQdlQ0tteAYOQEOTDd6IVlVtPY=; b=GjlhU7IoqaY718RNOR7DqWTG20zF6kOt5wgWynudn0ITp0+zDVD5QosZuVb9DcNI1E uLg7ZOVZiESDg9QBf+b2QS/Pn8Hc0gkXnTqzle1PVe0v7nwVonxi/nK9dqBJhmAlASAJ tuMCJ67J0Eu/2HZM0qT0wURiQPbKt5+sQ88DQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GxUQcGD1ekL/2d9GXVQdlQ0tteAYOQEOTDd6IVlVtPY=; b=cu5FWOELrcOoPnhhheN86cC4X2EavHel19qR+ojhSYtnU5seQngkblVCJfVUymf5ZI VWDSRcG9kYbDRBSVWwx5s/HTySMfWrQrlOi5Dld/DF2uEh+CrbWEWwvvA3jj3mMBB/he 2SRd4xmVt2SfuopHBRbDc+lmKLIxeMrGOy9QS3PoFE3Nrc854I5aOGJxuR9P1qjvom5E Lm+6Xrrf+rE6Dtvkh4BuhJrlzDlZ+ionuMy+N2L5JM0U93PU8tzxH5ktEFf60dIjCJXW c9bKWsn3vs8QSZAkevwXV9vX0+IznIzSmmX4pnxgkCYZQnuY4pXsjxS4u+Gbib6D3+az MQKQ== X-Gm-Message-State: ACrzQf2nw+HOqM/jDdZDfO6ZkKU0sP6g4BAJcBOaSOfFhEsoE40k27YQ 6vGQsurnU81FdRfcvpx4FU4BmQ== X-Google-Smtp-Source: AMsMyM4Ns1LVB+0LABBHOJzWrjQNzMAUk0lZthXzQw3TR/Rcm2joh9j3MHvMTSFHaR/HR+59oKPNuw== X-Received: by 2002:a17:902:8a90:b0:186:b145:f5ec with SMTP id p16-20020a1709028a9000b00186b145f5ecmr37462611plo.103.1667587137752; Fri, 04 Nov 2022 11:38:57 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d17-20020aa797b1000000b0056bcc744bdbsm2957812pfq.203.2022.11.04.11.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 11:38:57 -0700 (PDT) Date: Fri, 4 Nov 2022 11:38:56 -0700 From: Kees Cook To: Evan Green Cc: linux-kernel@vger.kernel.org, corbet@lwn.net, linux-pm@vger.kernel.org, rjw@rjwysocki.net, gwendal@chromium.org, apronin@chromium.org, Pavel Machek , Matthew Garrett , linux-integrity@vger.kernel.org, jejb@linux.ibm.com, zohar@linux.ibm.com, dlunev@google.com, Eric Biggers , Ben Boeckel , jarkko@kernel.org, Len Brown , "Rafael J. Wysocki" Subject: Re: [PATCH v4 07/11] PM: hibernate: Add kernel-based encryption Message-ID: <202211041135.EAC889BA08@keescook> References: <20221103180120.752659-1-evgreen@chromium.org> <20221103105558.v4.7.Ifff11e11797a1bde0297577ecb2f7ebb3f9e2b04@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103105558.v4.7.Ifff11e11797a1bde0297577ecb2f7ebb3f9e2b04@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Nov 03, 2022 at 11:01:15AM -0700, Evan Green wrote: > [...] > +config ENCRYPTED_HIBERNATION > + bool "Encryption support for userspace snapshots" > + depends on HIBERNATION_SNAPSHOT_DEV > + depends on CRYPTO_AEAD2=y > + default n "default n" is the, err, default, so this line can be left out. If someone more familiar with the crypto pieces can review the rest, that would be good. :) -- Kees Cook