From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: zohar@linux.ibm.com, noodles@fb.com, bauermann@kolabnow.com,
kexec@lists.infradead.org, linux-integrity@vger.kernel.org
Cc: code@tyhicks.com, nramas@linux.microsoft.com, paul@paul-moore.com
Subject: [PATCH 00/10] ima: measure events between kexec load and execute
Date: Mon, 3 Jul 2023 14:56:59 -0700 [thread overview]
Message-ID: <20230703215709.1195644-1-tusharsu@linux.microsoft.com> (raw)
The current Kernel behavior is IMA measurements snapshot is taken at
kexec 'load' and not at kexec 'execute'. IMA log is then carried
over to the new Kernel after kexec 'execute'.
Some devices can be configured to call kexec 'load' first, and followed
by kexec 'execute' after some time. (as opposed to calling 'load' and
'execute' in one single kexec command). In such scenario, if new IMA
measurements are added between kexec 'load' and kexec 'execute', the
TPM PCRs are extended with the IMA events between 'load' and 'execute';
but those IMA events are not carried over to the new kernel after kexec
soft reboot. This results in mismatch between TPM PCR quotes and the
actual IMA measurements list after the device boots into the new kexec
image. This mismatch results in the remote attestation failing for that
device.
This patch series proposes a solution to solve this problem by allocating
the necessary buffer at kexec 'load' time, and populating the buffer
with the IMA measurements at kexec 'execute' time.
The solution includes:
- addition of new functionality to allocate a buffer to hold IMA
measurements at kexec 'load',
- ima functionality to suspend and resume measurements as needed during
buffer copy at kexec 'execute',
- ima functionality for mapping the measurement list from the current
Kernel to the subsequent one,
- necessary changes to the kexec_file_load syscall, enabling it to call
the ima functions
- registering a reboot notifier which gets called during kexec 'execute',
- and removal of deprecated functions.
The modifications proposed in this series ensure the integrity of the ima
measurements is preserved across kexec soft reboots, thus significantly
improving the security of the Kernel post kexec soft reboots.
There were previous attempts to fix this issue [1], [2], [3]. But they
were not merged into the mainline Kernel.
We took inspiration from the past work [1] and [2] while working on this
patch series.
References:
-----------
[1] [PATHC v2 5/9] ima: on soft reboot, save the measurement list
https://lore.kernel.org/lkml/1472596811-9596-6-git-send-email-zohar@linux.vnet.ibm.com/
[2] PATCH v2 4/6] kexec_file: Add mechanism to update kexec segments.
https://lkml.org/lkml/2016/8/16/577
[3] [PATCH 1/6] kexec_file: Add buffer hand-over support
https://lore.kernel.org/linuxppc-dev/1466473476-10104-6-git-send-email-bauerman@linux.vnet.ibm.com/T/
Tushar Sugandhi (10):
ima: implement function to allocate buffer at kexec load
ima: implement function to populate buffer at kexec execute
ima: allocate buffer at kexec load to hold ima measurements
ima: implement functions to suspend and resume measurements
kexec: implement functions to map and unmap segment to kimage
ima: update buffer at kexec execute with ima measurements
ima: remove function ima_dump_measurement_list
ima: implement and register a reboot notifier function to update kexec
buffer
ima: suspend measurements while the kexec buffer is being copied
kexec: update kexec_file_load syscall to call ima_kexec_post_load
include/linux/ima.h | 3 +
include/linux/kexec.h | 13 ++
kernel/kexec_core.c | 72 +++++++++-
kernel/kexec_file.c | 7 +
kernel/kexec_internal.h | 1 +
security/integrity/ima/ima.h | 4 +
security/integrity/ima/ima_kexec.c | 211 +++++++++++++++++++++++------
security/integrity/ima/ima_queue.c | 32 +++++
8 files changed, 295 insertions(+), 48 deletions(-)
--
2.25.1
next reply other threads:[~2023-07-03 21:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 21:56 Tushar Sugandhi [this message]
2023-07-03 21:57 ` [PATCH 01/10] ima: implement function to allocate buffer at kexec load Tushar Sugandhi
2023-07-07 13:00 ` Mimi Zohar
2023-07-11 17:59 ` Tushar Sugandhi
2023-07-11 21:11 ` Mimi Zohar
2023-07-12 19:49 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 02/10] ima: implement function to populate buffer at kexec execute Tushar Sugandhi
2023-07-07 13:00 ` Mimi Zohar
2023-07-11 18:05 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 03/10] ima: allocate buffer at kexec load to hold ima measurements Tushar Sugandhi
2023-07-07 13:01 ` Mimi Zohar
2023-07-11 18:31 ` Tushar Sugandhi
2023-07-11 20:16 ` Stefan Berger
2023-07-12 19:39 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 04/10] ima: implement functions to suspend and resume measurements Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 05/10] kexec: implement functions to map and unmap segment to kimage Tushar Sugandhi
2023-07-07 12:28 ` Stefan Berger
2023-07-11 18:41 ` Tushar Sugandhi
2023-07-11 19:19 ` Stefan Berger
2023-07-12 19:51 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 06/10] ima: update buffer at kexec execute with ima measurements Tushar Sugandhi
2023-07-07 15:01 ` Mimi Zohar
2023-07-07 19:49 ` Mimi Zohar
2023-07-11 19:08 ` Tushar Sugandhi
2023-07-12 15:45 ` Mimi Zohar
2023-07-11 19:05 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 07/10] ima: remove function ima_dump_measurement_list Tushar Sugandhi
2023-07-07 13:55 ` Mimi Zohar
2023-07-11 19:11 ` Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 08/10] ima: implement and register a reboot notifier function to update kexec buffer Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 09/10] ima: suspend measurements while the kexec buffer is being copied Tushar Sugandhi
2023-07-03 21:57 ` [PATCH 10/10] kexec: update kexec_file_load syscall to call ima_kexec_post_load Tushar Sugandhi
2023-07-07 8:20 ` RuiRui Yang
2023-07-11 19:14 ` Tushar Sugandhi
2023-07-12 1:28 ` RuiRui Yang
2023-07-12 19:30 ` Tushar Sugandhi
2023-07-07 8:18 ` [PATCH 00/10] ima: measure events between kexec load and execute Dave Young
2023-07-11 17:52 ` Tushar Sugandhi
2023-07-07 15:55 ` Mimi Zohar
2023-07-11 17:51 ` Tushar Sugandhi
2023-09-22 18:59 ` Tushar Sugandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703215709.1195644-1-tusharsu@linux.microsoft.com \
--to=tusharsu@linux.microsoft.com \
--cc=bauermann@kolabnow.com \
--cc=code@tyhicks.com \
--cc=kexec@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=noodles@fb.com \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).