From: Jarkko Sakkinen <jarkko@kernel.org>
To: linux-integrity@vger.kernel.org
Cc: keyrings@vger.kernel.org, Jarkko Sakkinen <jarkko@kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
William Roberts <bill.c.roberts@gmail.com>,
Stefan Berger <stefanb@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>,
Peter Huewe <peterhuewe@gmx.de>,
Mario Limonciello <mario.limonciello@amd.com>,
Julien Gomes <julien@arista.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 5/6] tpm: Add tpm_buf_read_{u8,u16,u32}
Date: Tue, 24 Oct 2023 04:15:23 +0300 [thread overview]
Message-ID: <20231024011531.442587-6-jarkko@kernel.org> (raw)
In-Reply-To: <20231024011531.442587-1-jarkko@kernel.org>
Add tpm_buf_read_u8(), tpm_buf_read_u16() and tpm_read_u32() for the sake
of more convenient parsing of TPM responses.
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
drivers/char/tpm/tpm-buf.c | 69 ++++++++++++++++++++++++++++++++++++++
include/linux/tpm.h | 3 ++
2 files changed, 72 insertions(+)
diff --git a/drivers/char/tpm/tpm-buf.c b/drivers/char/tpm/tpm-buf.c
index f1d92d7e758d..bcd3cbcd9dd9 100644
--- a/drivers/char/tpm/tpm-buf.c
+++ b/drivers/char/tpm/tpm-buf.c
@@ -124,3 +124,72 @@ void tpm_buf_append_u32(struct tpm_buf *buf, const u32 value)
tpm_buf_append(buf, (u8 *)&value2, 4);
}
EXPORT_SYMBOL_GPL(tpm_buf_append_u32);
+
+/**
+ * tpm_buf_read() - Read from a TPM buffer
+ * @buf: &tpm_buf instance
+ * @offset: offset within the buffer
+ * @count: the number of bytes to read
+ * @output: the output buffer
+ */
+static void tpm_buf_read(const struct tpm_buf *buf, off_t *offset, size_t count, void *output)
+{
+ if (*(offset + count) >= buf->length) {
+ WARN(1, "tpm_buf: overflow\n");
+ return;
+ }
+
+ memcpy(output, &buf->data[*offset], count);
+ *offset += count;
+}
+
+/**
+ * tpm_buf_read_u8() - Read 8-bit word from a TPM buffer
+ * @buf: &tpm_buf instance
+ * @offset: offset within the buffer
+ *
+ * Return: next 8-bit word
+ */
+u8 tpm_buf_read_u8(const struct tpm_buf *buf, off_t *offset)
+{
+ u8 value;
+
+ tpm_buf_read(buf, offset, sizeof(value), &value);
+
+ return value;
+}
+EXPORT_SYMBOL_GPL(tpm_buf_read_u8);
+
+/**
+ * tpm_buf_read_u16() - Read 16-bit word from a TPM buffer
+ * @buf: &tpm_buf instance
+ * @offset: offset within the buffer
+ *
+ * Return: next 16-bit word
+ */
+u16 tpm_buf_read_u16(const struct tpm_buf *buf, off_t *offset)
+{
+ u16 value;
+
+ tpm_buf_read(buf, offset, sizeof(value), &value);
+
+ return be16_to_cpu(value);
+}
+EXPORT_SYMBOL_GPL(tpm_buf_read_u16);
+
+/**
+ * tpm_buf_read_u32() - Read 32-bit word from a TPM buffer
+ * @buf: &tpm_buf instance
+ * @offset: offset within the buffer
+ *
+ * Return: next 32-bit word
+ */
+u32 tpm_buf_read_u32(const struct tpm_buf *buf, off_t *offset)
+{
+ u32 value;
+
+ tpm_buf_read(buf, offset, sizeof(value), &value);
+
+ return be32_to_cpu(value);
+}
+EXPORT_SYMBOL_GPL(tpm_buf_read_u32);
diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index 687b5173bdab..6590bd1f0a0e 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -337,6 +337,9 @@ void tpm_buf_append(struct tpm_buf *buf, const u8 *new_data, u16 new_length);
void tpm_buf_append_u8(struct tpm_buf *buf, const u8 value);
void tpm_buf_append_u16(struct tpm_buf *buf, const u16 value);
void tpm_buf_append_u32(struct tpm_buf *buf, const u32 value);
+u8 tpm_buf_read_u8(const struct tpm_buf *buf, off_t *offset);
+u16 tpm_buf_read_u16(const struct tpm_buf *buf, off_t *offset);
+u32 tpm_buf_read_u32(const struct tpm_buf *buf, off_t *offset);
/*
* Check if TPM device is in the firmware upgrade mode.
--
2.42.0
next prev parent reply other threads:[~2023-10-24 1:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 1:15 [PATCH v3 0/6] Extend struct tpm_buf to support sized buffers (TPM2B) Jarkko Sakkinen
2023-10-24 1:15 ` [PATCH v3 1/6] tpm: Move buffer handling from static inlines to real functions Jarkko Sakkinen
2023-10-25 9:03 ` Jerry Snitselaar
2023-10-25 17:35 ` Jarkko Sakkinen
2023-10-26 17:10 ` Jerry Snitselaar
2023-10-26 17:55 ` James Bottomley
2023-10-26 18:19 ` Jerry Snitselaar
2023-11-05 21:59 ` Jarkko Sakkinen
2023-11-05 22:01 ` Jarkko Sakkinen
2023-11-05 22:42 ` James Bottomley
2023-11-05 21:57 ` Jarkko Sakkinen
2023-10-24 1:15 ` [PATCH v3 2/6] tpm: Store TPM buffer length Jarkko Sakkinen
2023-11-06 19:26 ` Jerry Snitselaar
2023-11-15 21:02 ` Jarkko Sakkinen
2023-11-06 19:36 ` Jerry Snitselaar
2023-11-15 21:04 ` Jarkko Sakkinen
2023-10-24 1:15 ` [PATCH v3 3/6] tpm: Detach tpm_buf_reset() from tpm_buf_init() Jarkko Sakkinen
2023-11-06 19:31 ` Jerry Snitselaar
2023-11-15 21:03 ` Jarkko Sakkinen
2023-10-24 1:15 ` [PATCH v3 4/6] tpm: Support TPM2 sized buffers (TPM2B) Jarkko Sakkinen
[not found] ` <d4157726d924a3ddad477923d6bcb4a8e6a55e60.camel@HansenPartnership.com>
2023-11-06 3:25 ` Jarkko Sakkinen
2023-11-07 17:20 ` Jerry Snitselaar
2023-11-15 21:24 ` Jarkko Sakkinen
2023-10-24 1:15 ` Jarkko Sakkinen [this message]
2023-10-24 1:38 ` [PATCH v3 5/6] tpm: Add tpm_buf_read_{u8,u16,u32} Mario Limonciello
2023-10-24 10:52 ` Jarkko Sakkinen
2023-10-27 12:24 ` James Bottomley
2023-11-06 3:22 ` Jarkko Sakkinen
2023-10-24 1:15 ` [PATCH v3 6/6] KEYS: trusted: tpm2: Use struct tpm_buf for sized buffers Jarkko Sakkinen
2023-11-15 21:56 ` [PATCH v3 0/6] Extend struct tpm_buf to support sized buffers (TPM2B) Stefan Berger
2023-11-19 22:05 ` Jarkko Sakkinen
2023-11-19 22:12 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024011531.442587-6-jarkko@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bill.c.roberts@gmail.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=julien@arista.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox