Re: [PATCH v1 1/1] tpm: tis-i2c: Add more compatible strings

Conor Dooley
2024-01-09T17:11:45Z

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Thu, Dec 14, 2023 at 08:49:53AM -0600, Ninad Palsule wrote:
> From: Joel Stanley <joel@jms.id.au>
>
> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>
> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>
> Add a compatible string for it, and the generic compatible.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> Link: https://lore.kernel.org/r/20220928043957.2636877-4-joel@jms.id.au
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>

I don't understand why you broke this series up and dropped patches.
NAK, these compatibles are not documented.

Cheers,
Conor.

> ---
> drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index a897402cc36a..9511c0d50185 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -383,6 +383,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> #ifdef CONFIG_OF
> static const struct of_device_id of_tis_i2c_match[] = {
> { .compatible = "infineon,slb9673", },
> + { .compatible = "nuvoton,npct75x", },
> + { .compatible = "tcg,tpm-tis-i2c", },
> {}
> };
> MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> --
> 2.39.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]