[PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p

[PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p

[Lukas Wunner]

Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
added a devicetree node for the Trusted Platform Module on certain
Gateworks boards.

The commit only used the generic "tcg,tpm_tis-spi" compatible string,
but public documentation shows that the chip is an ATTPM20P from Atmel
(nowadays Microchip):
https://trac.gateworks.com/wiki/tpm

Add the chip to the supported compatible strings of the TPM TIS SPI
driver.

For reference, a datasheet is available at:
https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: Tim Harvey <tharvey@gateworks.com>
---
 drivers/char/tpm/tpm_tis_spi_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
index c5c3197ee29f..7d376a642807 100644
--- a/drivers/char/tpm/tpm_tis_spi_main.c
+++ b/drivers/char/tpm/tpm_tis_spi_main.c
@@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
 MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
 
 static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
+	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
 	{ .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
 	{ .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
 	{ .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
-- 
2.40.1

Re: [PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p

[Jarkko Sakkinen]

On Sat Dec 23, 2023 at 11:34 AM EET, Lukas Wunner wrote:
> Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> added a devicetree node for the Trusted Platform Module on certain
> Gateworks boards.
>
> The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> but public documentation shows that the chip is an ATTPM20P from Atmel
> (nowadays Microchip):
> https://trac.gateworks.com/wiki/tpm
>
> Add the chip to the supported compatible strings of the TPM TIS SPI
> driver.
>
> For reference, a datasheet is available at:
> https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/char/tpm/tpm_tis_spi_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> index c5c3197ee29f..7d376a642807 100644
> --- a/drivers/char/tpm/tpm_tis_spi_main.c
> +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> @@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
>  MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
>  
>  static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> +	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
>  	{ .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
>  	{ .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
>  	{ .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@kernel.org>

BR, Jarkko

Re: [PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p

[Jarkko Sakkinen]

On Wed Jan 3, 2024 at 3:53 PM EET, Jarkko Sakkinen wrote:
> On Sat Dec 23, 2023 at 11:34 AM EET, Lukas Wunner wrote:
> > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> > added a devicetree node for the Trusted Platform Module on certain
> > Gateworks boards.
> >
> > The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> > but public documentation shows that the chip is an ATTPM20P from Atmel
> > (nowadays Microchip):
> > https://trac.gateworks.com/wiki/tpm
> >
> > Add the chip to the supported compatible strings of the TPM TIS SPI
> > driver.
> >
> > For reference, a datasheet is available at:
> > https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf
> >
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > Cc: Tim Harvey <tharvey@gateworks.com>
> > ---
> >  drivers/char/tpm/tpm_tis_spi_main.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> > index c5c3197ee29f..7d376a642807 100644
> > --- a/drivers/char/tpm/tpm_tis_spi_main.c
> > +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> > @@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
> >  MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
> >  
> >  static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> > +	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
> >  	{ .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
> >  	{ .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
> >  	{ .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@kernel.org>

Taking this back as checkpatch gives warning:

WARNING: DT compatible string "atmel,attpm20p" appears un-documented -- check ./Documentation/devicetree/bindings/
#36: FILE: drivers/char/tpm/tpm_tis_spi_main.c:330:
+	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },

BR, Jarkko

Re: [PATCH] tpm_tis_spi: Add compatible string atmel,attpm20p

[Lukas Wunner]

On Wed, Jan 03, 2024 at 03:57:00PM +0200, Jarkko Sakkinen wrote:
> On Wed Jan 3, 2024 at 3:53 PM EET, Jarkko Sakkinen wrote:
> > On Sat Dec 23, 2023 at 11:34 AM EET, Lukas Wunner wrote:
> > > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> > > added a devicetree node for the Trusted Platform Module on certain
> > > Gateworks boards.
> > >
> > > The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> > > but public documentation shows that the chip is an ATTPM20P from Atmel
> > > (nowadays Microchip):
> > > https://trac.gateworks.com/wiki/tpm
> > >
> > > Add the chip to the supported compatible strings of the TPM TIS SPI
> > > driver.
[...]
> > > --- a/drivers/char/tpm/tpm_tis_spi_main.c
> > > +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> > > @@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
> > >  MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
> > >  
> > >  static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> > > +	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
> > >  	{ .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
> > >  	{ .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
> > >  	{ .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@kernel.org>
> 
> Taking this back as checkpatch gives warning:
> 
> WARNING: DT compatible string "atmel,attpm20p" appears un-documented -- check ./Documentation/devicetree/bindings/
> #36: FILE: drivers/char/tpm/tpm_tis_spi_main.c:330:
> +	{ .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },

Yes, sorry for the confusion.

Before applying this patch, you'd first have to pick up this series
to clean up TPM dt-bindings (it has a Reviewed-by from Rob):

https://lore.kernel.org/all/cover.1702806810.git.lukas@wunner.de/

Plus the following patch I just submitted which adds "atmel,attpm20p"
to the dt-bindings (feel free to squash with the patch "dt-bindings:
tpm: Consolidate TCG TIS bindings" in the above-linked series):

https://lore.kernel.org/all/20240103155414.93-qGU4jYFy5x6c0EXMdyw2SO2Vyz5tChxsDLbWzSFE@z/

Note that there are two other patches pending to add missing compatible
strings to the driver, but they likewise depend on the above-linked
series to clean up TPM dt-bindings:

https://lore.kernel.org/all/096e5d9d22eaed0a256d2d9b315a77245bd423c6.1701095446.git.lukas@wunner.de/
https://lore.kernel.org/all/5c92620082189dc4e6be277952d0b46df26a6478.1702811113.git.lukas@wunner.de/

Thanks,

Lukas