[PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Vitor Soares]

From: Vitor Soares <vitor.soares@toradex.com>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
allowing module autoloading and leading to the following message:

  "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Based on:
  commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
Cc: stable@vger.kernel.org
Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
---
 drivers/char/tpm/tpm_tis_spi_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
index c9eca24bbad4..61b42c83ced8 100644
--- a/drivers/char/tpm/tpm_tis_spi_main.c
+++ b/drivers/char/tpm/tpm_tis_spi_main.c
@@ -318,6 +318,7 @@ static void tpm_tis_spi_remove(struct spi_device *dev)
 }
 
 static const struct spi_device_id tpm_tis_spi_id[] = {
+	{ "attpm20p", (unsigned long)tpm_tis_spi_probe },
 	{ "st33htpm-spi", (unsigned long)tpm_tis_spi_probe },
 	{ "slb9670", (unsigned long)tpm_tis_spi_probe },
 	{ "tpm_tis_spi", (unsigned long)tpm_tis_spi_probe },
-- 
2.34.1

Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Lukas Wunner]

[removing stable@vger.kernel.org from cc -- they're only interested
in your patch once it's in Linus' tree]

On Fri, Jun 21, 2024 at 10:50:45AM +0100, Vitor Soares wrote:
> "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> allowing module autoloading and leading to the following message:
> 
>   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
[...]
> Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> 
> Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>

Reviewed-by: Lukas Wunner <lukas@wunner.de>

The old problem that spi modules aren't auto-loaded based on
MODULE_DEVICE_TABLE(of, ...), but only on MODULE_DEVICE_TABLE(spi, ...):

https://lore.kernel.org/all/20170811081429.GA9957@wunner.de/

Completely forgot that this is still a problem after all these years. :(

Thanks,

Lukas

Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Jarkko Sakkinen]

On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote:
> From: Vitor Soares <vitor.soares@toradex.com>
> 
> "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> allowing module autoloading and leading to the following message:
> 
>   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
> 
> Based on:
>   commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")
> 
> Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> 
> Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>

This is not a bug fix. This is a feature.

BR, Jarkko

Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Francesco Dolcini]

On Mon, Jul 01, 2024 at 03:02:11PM +0000, Jarkko Sakkinen wrote:
> On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote:
> > From: Vitor Soares <vitor.soares@toradex.com>
> > 
> > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> > allowing module autoloading and leading to the following message:
> > 
> >   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
> > 
> > Based on:
> >   commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")
> > 
> > Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> > 
> > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
> 
> This is not a bug fix. This is a feature.

I believe that some maintainer have a different view on this kind of
patches compared to you, adding new device id would be material for
stable, or this specific issue preventing module auto loading.

I noticed that this specific view is not new from you, see
https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.

With that said, I am ok with it.

Do you want a new patch version without Fixes/Cc:stable tags or you can
remove those while applying?

Francesco

Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Jarkko Sakkinen]

On Mon, 2024-07-01 at 17:14 +0200, Francesco Dolcini wrote:
> On Mon, Jul 01, 2024 at 03:02:11PM +0000, Jarkko Sakkinen wrote:
> > On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote:
> > > From: Vitor Soares <vitor.soares@toradex.com>
> > > 
> > > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> > > allowing module autoloading and leading to the following message:
> > > 
> > >   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
> > > 
> > > Based on:
> > >   commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")
> > > 
> > > Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> > > 
> > > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
> > 
> > This is not a bug fix. This is a feature.
> 
> I believe that some maintainer have a different view on this kind of
> patches compared to you, adding new device id would be material for
> stable, or this specific issue preventing module auto loading.
> 
> I noticed that this specific view is not new from you, see
> https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.
> 
> With that said, I am ok with it.
> 
> Do you want a new patch version without Fixes/Cc:stable tags or you can
> remove those while applying?
> 
> Francesco

Hmm... OK, I'll apply this version, I see your point here!

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

[Jarkko Sakkinen]

On Mon, 2024-07-01 at 15:27 +0000, Jarkko Sakkinen wrote:
> On Mon, 2024-07-01 at 17:14 +0200, Francesco Dolcini wrote:
> > On Mon, Jul 01, 2024 at 03:02:11PM +0000, Jarkko Sakkinen wrote:
> > > On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote:
> > > > From: Vitor Soares <vitor.soares@toradex.com>
> > > > 
> > > > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> > > > allowing module autoloading and leading to the following message:
> > > > 
> > > >   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
> > > > 
> > > > Based on:
> > > >   commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")
> > > > 
> > > > Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> > > > 
> > > > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
> > > 
> > > This is not a bug fix. This is a feature.
> > 
> > I believe that some maintainer have a different view on this kind of
> > patches compared to you, adding new device id would be material for
> > stable, or this specific issue preventing module auto loading.
> > 
> > I noticed that this specific view is not new from you, see
> > https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.
> > 
> > With that said, I am ok with it.
> > 
> > Do you want a new patch version without Fixes/Cc:stable tags or you can
> > remove those while applying?
> > 
> > Francesco
> 
> Hmm... OK, I'll apply this version, I see your point here!
> 
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Should be soon available in -next.

BR, Jarkko