From: Jason Gunthorpe <jgg@ziepe.ca>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: linux-coco@lists.linux.dev, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>, "H. Peter Anvin" <hpa@zytor.com>,
linux-integrity@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
x86@kernel.org, Joerg Roedel <jroedel@suse.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Dov Murik <dovmurik@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 3/3] x86/sev: add a SVSM vTPM platform device
Date: Tue, 10 Dec 2024 10:40:25 -0400 [thread overview]
Message-ID: <20241210144025.GG1888283@ziepe.ca> (raw)
In-Reply-To: <20241210143423.101774-4-sgarzare@redhat.com>
On Tue, Dec 10, 2024 at 03:34:23PM +0100, Stefano Garzarella wrote:
> + if (platform_device_add_data(&tpm_device, &pops, sizeof(pops)))
> + return -ENODEV;
> + if (platform_device_register(&tpm_device))
> + return -ENODEV;
This seems like an old fashioned way to instantiate a device. Why do
this? Just put the TPM driver here and forget about pops? Simple tpm
drivers are not very complex.
Jason
next prev parent reply other threads:[~2024-12-10 14:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 14:34 [PATCH 0/3] Enlightened vTPM support for SVSM on SEV-SNP Stefano Garzarella
2024-12-10 14:34 ` [PATCH 1/3] tpm: add generic platform device Stefano Garzarella
2024-12-12 9:51 ` Stefano Garzarella
2024-12-12 14:35 ` James Bottomley
2024-12-12 15:30 ` Stefano Garzarella
2024-12-12 15:41 ` James Bottomley
2024-12-12 16:12 ` Stefano Garzarella
2024-12-10 14:34 ` [PATCH 2/3] x86/sev: add SVSM call macros for the vTPM protocol Stefano Garzarella
2024-12-10 14:34 ` [PATCH 3/3] x86/sev: add a SVSM vTPM platform device Stefano Garzarella
2024-12-10 14:40 ` Jason Gunthorpe [this message]
2024-12-10 14:55 ` James Bottomley
2024-12-10 15:04 ` Jason Gunthorpe
2024-12-11 8:19 ` Stefano Garzarella
2024-12-11 15:00 ` Jason Gunthorpe
2024-12-11 15:38 ` Stefano Garzarella
2024-12-11 15:53 ` Jason Gunthorpe
2024-12-11 16:42 ` Stefano Garzarella
2024-12-19 15:35 ` Stefano Garzarella
2024-12-19 15:40 ` Jarkko Sakkinen
2024-12-19 16:06 ` Stefano Garzarella
2025-01-14 10:42 ` Stefano Garzarella
2025-01-14 13:07 ` Jason Gunthorpe
2025-01-14 16:51 ` Stefano Garzarella
2025-01-14 17:33 ` Jason Gunthorpe
2025-01-14 22:46 ` Jarkko Sakkinen
2025-01-14 22:48 ` Jarkko Sakkinen
2025-01-14 23:12 ` Jarkko Sakkinen
2025-01-22 21:29 ` Dionna Amalie Glaze
2025-01-23 9:50 ` Jarkko Sakkinen
2025-01-23 10:09 ` Stefano Garzarella
2025-01-23 11:46 ` Jarkko Sakkinen
2025-01-23 11:49 ` Jarkko Sakkinen
2025-01-23 12:29 ` Stefano Garzarella
2024-12-11 16:30 ` Tom Lendacky
2024-12-11 16:55 ` Stefano Garzarella
2024-12-11 17:02 ` James Bottomley
2024-12-13 11:48 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210144025.GG1888283@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bp@alien8.de \
--cc=cclaudio@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dovmurik@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jroedel@suse.de \
--cc=linux-coco@lists.linux.dev \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox