From: Jason Gunthorpe <jgg@ziepe.ca>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [RFC PATCH 3/3] tpm/tpm_svsm: use send_recv() op
Date: Wed, 19 Mar 2025 16:58:18 -0300 [thread overview]
Message-ID: <20250319195818.GC126678@ziepe.ca> (raw)
In-Reply-To: <20250311100130.42169-4-sgarzare@redhat.com>
On Tue, Mar 11, 2025 at 11:01:30AM +0100, Stefano Garzarella wrote:
> This driver does not support interrupts, and receiving the response is
> synchronous with sending the command.
>
> Let's simplify the driver by implementing the new send_recv() op.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> Note: this is based on "[PATCH v3 0/4] Enlightened vTPM support for SVSM
> on SEV-SNP" series [1].
> If we will merge this series before it, we can just ignore this patch
> and I'll squash these changes in that series.
>
> [1] https://lore.kernel.org/linux-integrity/20250311094225.35129-1-sgarzare@redhat.com/
> ---
> drivers/char/tpm/tpm_svsm.c | 46 ++++++++-----------------------------
> 1 file changed, 9 insertions(+), 37 deletions(-)
I think the diffstat speaks for itself, you should send this as
non-RFC
Jason
next prev parent reply other threads:[~2025-03-19 19:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:01 [RFC PATCH 0/3] tpm: add send_recv() op and use it in tpm_ftpm_tee and tpm_svsm drivers Stefano Garzarella
2025-03-11 10:01 ` [RFC PATCH 1/3] tpm: add send_recv() op in tpm_class_ops Stefano Garzarella
2025-03-11 10:01 ` [RFC PATCH 2/3] tpm/tpm_ftpm_tee: use send_recv() op Stefano Garzarella
2025-03-13 9:12 ` Sumit Garg
2025-03-13 12:59 ` Jens Wiklander
2025-03-18 10:55 ` Stefano Garzarella
2025-03-11 10:01 ` [RFC PATCH 3/3] tpm/tpm_svsm: " Stefano Garzarella
2025-03-19 19:58 ` Jason Gunthorpe [this message]
2025-03-20 11:15 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319195818.GC126678@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox