* [PATCH] ima_setup.sh: Fix signed policy requirement check
@ 2026-01-28 12:58 Petr Vorel
2026-01-28 18:17 ` Mimi Zohar
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2026-01-28 12:58 UTC (permalink / raw)
To: ltp; +Cc: Petr Vorel, Mimi Zohar, linux-integrity, Li Wang, Cyril Hrubis
tst_require_kconfigs() quits testing with tst_brk TCONF, but that first
hides the explanation in ima_conditionals.sh (which also calls tst_brk
TCONF) but also quits testing in ima_policy.sh (which calls tst_res
TCONF). Therefore use tst_check_kconfigs binary instead.
Fixes: c38b528783 ("ima_{conditionals, policy}: Handle policy required to be signed")
Reported-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
FYI Fix needed before the release.
testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
index df0b8d1532..b69d7c31d9 100644
--- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
+++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
@@ -469,7 +469,7 @@ require_evmctl()
# d958083a8f640 ("x86/ima: define arch_get_ima_policy() for x86") # v5.0
check_need_signed_policy()
{
- tst_secureboot_enabled && tst_kvcmp -ge '6.5' && tst_require_kconfigs \
+ tst_secureboot_enabled && tst_kvcmp -ge '6.5' && tst_check_kconfigs \
'CONFIG_IMA_KEYRINGS_PERMIT_SIGNED_BY_BUILTIN_OR_SECONDARY,CONFIG_IMA_ARCH_POLICY'
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ima_setup.sh: Fix signed policy requirement check
2026-01-28 12:58 [PATCH] ima_setup.sh: Fix signed policy requirement check Petr Vorel
@ 2026-01-28 18:17 ` Mimi Zohar
2026-01-28 20:31 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Mimi Zohar @ 2026-01-28 18:17 UTC (permalink / raw)
To: Petr Vorel, ltp; +Cc: linux-integrity, Li Wang, Cyril Hrubis
On Wed, 2026-01-28 at 13:58 +0100, Petr Vorel wrote:
> tst_require_kconfigs() quits testing with tst_brk TCONF, but that first
> hides the explanation in ima_conditionals.sh (which also calls tst_brk
> TCONF) but also quits testing in ima_policy.sh (which calls tst_res
> TCONF). Therefore use tst_check_kconfigs binary instead.
>
> Fixes: c38b528783 ("ima_{conditionals, policy}: Handle policy required to be signed")
> Reported-by: Mimi Zohar <zohar@linux.ibm.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> FYI Fix needed before the release.
Thanks, Petr!
Tested-by: Mimi Zohar <zohar@linux.ibm.com>
>
> testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> index df0b8d1532..b69d7c31d9 100644
> --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> @@ -469,7 +469,7 @@ require_evmctl()
> # d958083a8f640 ("x86/ima: define arch_get_ima_policy() for x86") # v5.0
> check_need_signed_policy()
> {
> - tst_secureboot_enabled && tst_kvcmp -ge '6.5' && tst_require_kconfigs \
> + tst_secureboot_enabled && tst_kvcmp -ge '6.5' && tst_check_kconfigs \
> 'CONFIG_IMA_KEYRINGS_PERMIT_SIGNED_BY_BUILTIN_OR_SECONDARY,CONFIG_IMA_ARCH_POLICY'
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ima_setup.sh: Fix signed policy requirement check
2026-01-28 18:17 ` Mimi Zohar
@ 2026-01-28 20:31 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2026-01-28 20:31 UTC (permalink / raw)
To: Mimi Zohar; +Cc: ltp, linux-integrity, Li Wang, Cyril Hrubis
Hi Mimi,
...
> > ---
> > FYI Fix needed before the release.
> Thanks, Petr!
> Tested-by: Mimi Zohar <zohar@linux.ibm.com>
Thanks a lot for testing, I really appreciate that!
Merged.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 12:58 [PATCH] ima_setup.sh: Fix signed policy requirement check Petr Vorel
2026-01-28 18:17 ` Mimi Zohar
2026-01-28 20:31 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox