From: Stefan Berger <stefanb@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: zohar@linux.ibm.com, roberto.sassu@huawei.com,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [ima-evm-utils: PATCH 5/8] Use imaevm_create_sigv3 for fsverity signature creation
Date: Tue, 24 Mar 2026 18:03:11 -0400 [thread overview]
Message-ID: <20260324220314.743709-6-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20260324220314.743709-1-stefanb@linux.ibm.com>
Convert the code that built the fsverity signature with V3 signing scheme
to use the new imaevm_create_sigv3 function.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
src/evmctl.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/evmctl.c b/src/evmctl.c
index 2843ff8..0a38aa7 100644
--- a/src/evmctl.c
+++ b/src/evmctl.c
@@ -828,7 +828,6 @@ static int cmd_sign_ima(struct command *cmd)
*/
static int cmd_sign_hash(struct command *cmd)
{
- unsigned char sigv3_hash[MAX_DIGEST_SIZE];
unsigned char sig[MAX_SIGNATURE_SIZE];
unsigned char hash[MAX_DIGEST_SIZE];
size_t algolen = 0;
@@ -840,7 +839,6 @@ static int cmd_sign_hash(struct command *cmd)
const char *key;
char algo[7]; /* Current maximum fsverity hash algo name length */
ssize_t len;
- int ret;
key = imaevm_params.keyfile ? : "/etc/keys/privkey_evm.pem";
@@ -888,19 +886,15 @@ static int cmd_sign_hash(struct command *cmd)
assert(hashlen / 2 <= sizeof(hash));
hex2bin(hash, hashp, hashlen / 2);
- ret = calc_hash_sigv3(IMA_VERITY_DIGSIG, algo, hash,
- sigv3_hash);
- if (ret < 0 || ret == 1) {
- log_info("Failure to calculate fs-verity hash\n");
- continue;
- }
-
- siglen = imaevm_signhash(algo, sigv3_hash, hashlen / 2,
- key, g_keypass, sig + 1, sigflags,
- &access_info, imaevm_keyid);
-
- sig[0] = IMA_VERITY_DIGSIG;
- sig[1] = DIGSIG_VERSION_3; /* sigv3 */
+ psig = sig;
+ siglen = imaevm_create_sigv3(algo, hash,
+ hashlen / 2, key, g_keypass,
+ &psig, sizeof(sig), sigflags,
+ IMA_VERITY_DIGSIG,
+ &access_info, imaevm_keyid);
+ if (siglen <= 1)
+ return siglen;
+ assert(siglen <= (int)sizeof(sig));
} else {
/* Parse the shaXsum output */
token = strpbrk(line, " \t");
--
2.53.0
next prev parent reply other threads:[~2026-03-24 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 22:03 [ima-evm-utils: PATCH 0/8] Add sigv3 support for IMA and EVM and all key types Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 1/8] Implement imaevm_create_sigv3 for creating V3 signatures Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 2/8] Implement support for IMA signatures V3 signing scheme Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 3/8] Implement support for EVM " Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 4/8] Support v3 IMA and EVM file signatures with --v3 option Stefan Berger
2026-03-24 22:03 ` Stefan Berger [this message]
2026-03-24 22:03 ` [ima-evm-utils: PATCH 6/8] tests: Add new --v3 option to sign_verify tests Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 7/8] Allow verification of EVM_XATTR_PORTABLE_DIGSIG with sigv3 Stefan Berger
2026-03-24 22:03 ` [ima-evm-utils: PATCH 8/8] Allow hashing for sigv3 on EVM_XATTR_PORTABLE_DIGSIG Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324220314.743709-6-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox