From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792598436; b=eaWLdWaqWW38DX0hltcDTdKFHyxAvPy2Lxaq2ca/2Y8/Xugkexpoxub1LxZBJZ6833w+ RNamne5A2dPrOj2OkIh+K5Ne0WBn8kaVS3fFQdF+jlct8yq9/ZaU+4jgtasYXDCZjUUsM LMIrDrvIy/vpP2MoFGiaZjW3sQn2MXx+U1febMjyzC5hjRszUn0VUQINl3y+6IHg9FzKg FcT4bo931e81Xxjq2brqVJXN3lOvH2SNqzswBgTmV1Nka83z9X2vDxSm/0LQJhbko9+E8 7PN3K+9t6dOdgQwdlPtrPcvLwJ922SQwsin1+r9FWqWFwrCIsYaA6k9y+bYUCMWzkLw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792598436; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:In-Reply-To:References:Organization:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Authority-Analysis:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=ZCSVqnmCg2tgiS2qJzUGfrVmwaXnekD3uvjwV9akWpI=; b=lyYtb/GbOANccOToTSvvwDhwryu2ShLwyR2zcEkIby9kN8y6JPb017W0ZUFbIKRsp/Ci +yP4nnd5c5onmPgmwBnRnBtD3hjtv6Z1U2T5XFuIkMm2YZ8i3kOt89jdhf6i0jlGiWn3D YS5NjHhoyp3miGkeM7yU2jTJs9ip7Ca5xt4l1ea6qJs97K89Ww802h7cHtoZy4SE3J1sr VngltisrfkgOZarSi4yQ5+8HmX8ZO+ATuOK31C/0lOHzIhvcA730xRhOdX8+YK82AOekR E7NxY29TCvXJZo5Hp+eck5zTXC8sB0FcXC0rXqBE7wLeFVY1Nb8Ccu48yjzKQDkeBfg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=fwgbev1Y; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Q2tlbF2T; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59FF7606A31B for ; Wed, 21 Oct 2026 16:00:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 59FF7606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=fwgbev1Y; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Q2tlbF2T Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69LFU0jx682104 for ; Wed, 21 Oct 2026 16:00:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZCSVqnmCg2tgiS2qJzUGfrVmwaXnekD3uvjwV9akWpI=; b=fwgbev1Y755yo0Wk UtrQff0d+SDedqVBkyUwA25GdbsQr1gedtRARzdBI/EmAOe0XsQToYsDxG3dcNo7 WzxSgYac/ZGOsmY8agUmPRwldZjLtqwf49ThqvX1StCK7jmI7HXPKz+sOHF/9RsX d2pytN0NJDGCo1MhMPxlfFPfca6UKvw74dPxLEl0uCzKdYPb+HZyLX3GECv4+38B 1RGJ0zWdQGHzDf3e0b63brnwjxFoTAwfwuugTBfdk1u7TM1ZeuovSwyIH11w2+ZW SdnPxbpBiqOcHpBXKX9x9UDSHSBDxYFiyv72OFxlygXqyI/101YubsytU9S9Gndm 8d/hEg== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hex7vrq21-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Oct 2026 16:00:29 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-36803927a49so1320494eec.1 for ; Wed, 21 Oct 2026 09:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792598428; x=1793203228; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ZCSVqnmCg2tgiS2qJzUGfrVmwaXnekD3uvjwV9akWpI=; b=Q2tlbF2TrLWZ8WCd1iDkCT/5A7bIP778/bGJSMgFeMYPGy1HjZ0EiwgkRZ1lhWOCGO VKn8WZMhwAZZohJhk9LvzbzgTV8gA5UC1PE7uwZR0SuRwoutQY1q3lkEMGBv3fuAMK0Y IlQlYeWPVxpZ4Gdw727J4mm3WcZZzNMD9S52o8D9UCyyDRYoAJEWLnmIUfmV2AqfRaHB SUOcZ7492XJRWTccR/T6+Hfj0BD4/XPZwkhu8Mv+Ok7z6/ydar+z2JxOJpPnPm1Debuc rfHf+Ua+vqbqkEHGDbCLNjrMtVty+4CROjLoZsEXNVbWRYk4jUd3utyStnHcMwc2DjaE FXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792598428; x=1793203228; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZCSVqnmCg2tgiS2qJzUGfrVmwaXnekD3uvjwV9akWpI=; b=wD9F06c2epyvUbLhSDfONIi8gEQIxeeAl8QhR/85xk7NR7phhwdKg9i6ERFtDVGSEj cmnXi5dxtjYg2aMd/166MhVLlvzs/6tifJjWpPYHZQRhnbCuNVAUtqFwwBpekCSA8ZFu Ca6zCDGavT33l7I15fM1mrM33OJn/eZtz2Hbtg8K9+itGfut9hznVCtfthjNLvkwSUjG gCl7i5qCzwSidkTvoHqM1CWy8fcPJjK4TgVDii4AhIdPpUd5GGbxk7Si8K1pIUx14u/5 Jkygyl+hMlAfonFpSDY1sIkH7b+uzrZaIFzVuejgl08JxWq/+TZoFAFqbYfgEnkvdGHf 4ACw== X-Forwarded-Encrypted: i=1; AKwUvBzUr2p9Bq2jR52t97f/xEm+dG1ZorIUBq4Q0uRN3DHNGr7nH/fEwde3cvU94faUw+/jBJqa0V9plqcadoJa2v8=@vger.kernel.org X-Gm-Message-State: AFq9FYLC4Lj/ZQv3V8b4uovbJf2rGabtSO2DFEs9/FbEp9rzAwCCQ2mX lRlAIInhBGqIZeo0h5oUnKmXdcSkuxMWj7mYulioYm4zcsPXMxkuSp6zCL6Ioyn6Rf9r24Bosfs xF38MLFh36+kO+WE1n+OGD8ypJYG9m4MvtqZl6dB9t71T3CU/nvqITb2/NTkfEHLOHgjHZzE= X-Gm-Gg: AYBFou00+JcI+XwaAzXO9SSKBKGR8kU3psCojT0Y0tTBFLcZKS/M/iwwftD+bEkxPro ffrC67F+nI7QUG0rBrNz1qnt+mxu/wXAzsTODmKG/dmx026GMxbugw+QF1aQFwVTJp7rnKioqA1 rUOatGd5FrvwHAq1DKL5jOtvSCVB6negUQxQmfc6YrsfdAoln86Dt+Mv/jH9v66V3/t75FvLD9i 76Q+ZaD1k7iCBWS/nDMlhQ4XXk2VOeDo0NmNhBwbqQiQEa2O0HHWdPbYgeAMqK97PRbHiHI3Ti4 G4+ZCq/Z4GGljM+tmO7j24GKYHCXO6tkKVl7ao+ua0CoxHsNArs43EjUsqt4yo3K2v094nMy8s6 HS82/XMpygmky0vsKPAvMho08gmFAXxSh+Ck6WB1U9w== X-Received: by 2002:a05:7300:106:b0:35d:d9a9:e455 with SMTP id 5a478bee46e88-3674ef292b9mr4299667eec.21.1792598427204; Wed, 21 Oct 2026 09:00:27 -0700 (PDT) X-Received: by 2002:a05:7300:106:b0:35d:d9a9:e455 with SMTP id 5a478bee46e88-3674ef292b9mr4299533eec.21.1792598425455; Wed, 21 Oct 2026 09:00:25 -0700 (PDT) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-367405ed2absm10188327eec.5.2026.10.21.09.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 09:00:24 -0700 (PDT) Date: Wed, 21 Oct 2026 09:00:19 -0700 From: Jonathan Cameron To: Jason Gunthorpe Cc: Alexandre Ghiti , Albert Ou , Ard Biesheuvel , Arnd Bergmann , Catalin Marinas , Jonathan Corbet , David Sterba , Ilias Apalodimas , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Randy Dunlap , Simon Glass , Shuah Khan , Nick Terrell , Will Deacon , Alexandre Ghiti , Conor Dooley , linux-integrity@vger.kernel.org, Palmer Dabbelt , patches@lists.linux.dev, Piotr =?ISO-8859-1?Q?Kr=F3l?= , Ross Philipson , Sami Tolvanen , Song Shuai Subject: Re: [PATCH v2 02/15] efi/riscv: libstub: Don't set image_size in handle_kernel_image() Message-ID: <20261021090019.000060c4@oss.qualcomm.com> In-Reply-To: <2-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> References: <0-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> <2-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Mailing-List: linux-integrity@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: GknKXJaunzi7Dy9FU7M5F6rk77Asc8Mz X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIxMDA2MyBTYWx0ZWRfX06RjWM7MiEnh 2WI6S3tY4xrh0B++bdzmgUnqM+JTLieuIVinf+ghQrpbvTgeVs9tAcP41m/zHRIxbZK3uyC9PIo 9Fw0JNgWdX718eN7mgOgDMyxp/YJOaE= X-Proofpoint-GUID: GknKXJaunzi7Dy9FU7M5F6rk77Asc8Mz X-Authority-Analysis: v=2.4 cv=e4uT2qp/ c=1 sm=1 tr=0 ts=6ad8e19d cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Ikd4Dj_1AAAA:8 a=xbFV6RGmdEKkzbgyJ_QA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIxMDA2MyBTYWx0ZWRfX0voe82Lxw8ac LP4V5eoINVO/EMPznEIiOzHAYmf2MQTLLhvxvX8sUqra0gYPU3+Ta/FsWlWOVm24EoQU5q3KVUu nOjwuyhVztCex1N1o9Z5nPHL6E5tcoKkaCYzhuVuWMAzSlxzPBkY3g8FhxpeZRciFfZLKR1sX90 dB63ndcD+5WTTwEV+UPV0aQnPDOaHv1Xo/98sdkrX8GUGlud93QRUTdKmfoV2m7F/LDsJtRZBAW ugE2Rmo8VvmewzctZ9sifYbtPyE29NjbdyKVw2mgKgpcr9sxN3LXHWPM/XsOstIWd+DEkpoSHRc 9q12x3OEI895Kr/C+kj4nOkwFl67fepcH2HDwrjrWb3L32dgmLW6gasZmjAMkTrF3Ifa+Ty+eV8 RnTPXI9na4kmkeZ0BIkCURlKOZ42apJ/3nqJvmvbC6rmYbG4PpRGaDnM2GurTmF9UuS37H05mI0 hpiI4dA1hG3Ntx8dAlQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-21_04,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610210063 On Fri, 2 Oct 2026 20:31:39 -0300 Jason Gunthorpe wrote: > Sashiko points out the image_size should only be set if image_addr was > reassigned to some allocated memory. If image_size is not zero then the > caller will free the image_addr pointer. > > efi_kaslr_relocate_kernel() never works like that, if it changes > image_addr to allocated memory the free is done through reserve_size. > > Fixes: b7ac4b8ee73d ("riscv: libstub: Implement KASLR by using generic functions") > Signed-off-by: Jason Gunthorpe Hi Jason, This made me curious on the differences across architectures... Looks like there is perhaps some room to make them look more similar at least! One small step below. > --- > drivers/firmware/efi/libstub/riscv-stub.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/firmware/efi/libstub/riscv-stub.c b/drivers/firmware/efi/libstub/riscv-stub.c > index e7d9204baee312..725b634c517919 100644 > --- a/drivers/firmware/efi/libstub/riscv-stub.c > +++ b/drivers/firmware/efi/libstub/riscv-stub.c > @@ -37,17 +37,14 @@ efi_status_t handle_kernel_image(unsigned long *image_addr, > kernel_codesize = __init_text_end - _start; > kernel_memsize = kernel_size + (_end - _edata); > *image_addr = (unsigned long)_start; > - *image_size = kernel_memsize; > - *reserve_size = *image_size; > + *reserve_size = kernel_memsize; > > status = efi_kaslr_relocate_kernel(image_addr, > reserve_addr, reserve_size, > kernel_size, kernel_codesize, kernel_memsize, > efi_kaslr_get_phys_seed(image_handle)); > - if (status != EFI_SUCCESS) { > + if (status != EFI_SUCCESS) > efi_err("Failed to relocate kernel\n"); This print is replicated at the caller, so can drop this as well I think. > - *image_size = 0; > - } > > return status; > }