From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: "Justin M. Forbes" <jforbes@fedoraproject.org>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jmforbes@linuxtx.org
Subject: Re: [PATCH] Fix typo in tpmrm class definition
Date: Sat, 9 Sep 2023 23:58:13 +0400 [thread overview]
Message-ID: <2cb0fd0d-acc7-8cdd-85ad-b75ba36afef1@gmail.com> (raw)
In-Reply-To: <20230908140629.2930150-1-jforbes@fedoraproject.org>
On 08.09.2023 18:06, Justin M. Forbes wrote:
> Commit d2e8071bed0be ("tpm: make all 'class' structures const")
> unfortunately had a typo for the name on tpmrm.
>
> Fixes: d2e8071bed0b ("tpm: make all 'class' structures const")
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> ---
> drivers/char/tpm/tpm-chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 23f6f2eda84c..42b1062e33cd 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -33,7 +33,7 @@ const struct class tpm_class = {
> .shutdown_pre = tpm_class_shutdown,
> };
> const struct class tpmrm_class = {
> - .name = "tmprm",
> + .name = "tpmrm",
> };
> dev_t tpm_devt;
>
Hi Justin,
Thank you for fixing this mistake, it's my bad :(
I'm not sure if you know this or not, but merge window is still opened,
so the patch could be accidentally skipped by maintainers as they have a
huge load during this period... Perhaps resending it in a few days might
be a good idea.
Also, probably adding 'tpm:' prefix to the commit title could make it
more noticeable to the maintainers.
Thank you again for doing this.
--
Kind regards,
Ivan Orlov
next prev parent reply other threads:[~2023-09-09 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 14:06 [PATCH] Fix typo in tpmrm class definition Justin M. Forbes
2023-09-09 19:58 ` Ivan Orlov [this message]
2023-09-11 21:48 ` Jarkko Sakkinen
2023-09-11 21:53 ` Jarkko Sakkinen
2023-09-11 22:34 ` Justin Forbes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb0fd0d-acc7-8cdd-85ad-b75ba36afef1@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=jforbes@fedoraproject.org \
--cc=jgg@ziepe.ca \
--cc=jmforbes@linuxtx.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox