From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-integrity-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ED1DDEB64D9
	for <linux-integrity@archiver.kernel.org>; Mon, 10 Jul 2023 18:38:08 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230167AbjGJSiI (ORCPT
        <rfc822;linux-integrity@archiver.kernel.org>);
        Mon, 10 Jul 2023 14:38:08 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50494 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229970AbjGJSiH (ORCPT
        <rfc822;linux-integrity@vger.kernel.org>);
        Mon, 10 Jul 2023 14:38:07 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFF09DF;
        Mon, 10 Jul 2023 11:38:06 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 47A7661193;
        Mon, 10 Jul 2023 18:38:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ACE2C433C7;
        Mon, 10 Jul 2023 18:38:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1689014285;
        bh=oDS27tMrJVOBiZY57a+Ie8tABqwg5aAwz9QA3VZd2U0=;
        h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
        b=ru2Zb17q5QYtxC+JqO+OEMltt4uxzx5xdMQUW79j/15YksroEXdTBaBSGQpUFBNuD
         E6JTSOGUzIwNCWN7KDkLBwVUfcy9weJmES0ws49q8Yd2LLnC496c3HEyK/oLqhWnlJ
         6y6UYAvU3Fft1iEU/MvvYw2fU4Qbx6b+k/aJ8s/6DbNr5RyuvC7DhXu1h8p0wKSqUu
         UUyVoJBD6deIMTb8hg/gWt0caQsvAfJhHzx2gKGjCmZJgT3Djm8m1DFhLWxXOXV5Ls
         uwjl6xkDtPSLqQ/U09FE5kRfWHwn6xvhOFRX10ga9mt7ERoC1jXItAJoCnzV60lmMg
         Glki5J1aqPAKQ==
Message-ID: <36a25631960bc178b318e319f1db0d4d275c910f.camel@kernel.org>
Subject: Re: [PATCH v2 1/2] tpm/tpm_tis: Disable interrupts for Framework
 Laptop Intel 12th gen
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Jason Gunthorpe <jgg@ziepe.ca>, Christian Hesse <mail@eworm.de>
Cc:     linux-integrity@vger.kernel.org,
        Thorsten Leemhuis <regressions@leemhuis.info>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        Linux kernel regressions list <regressions@lists.linux.dev>,
        Peter Huewe <peterhuewe@gmx.de>, stable@vger.kernel.org,
        roubro1991@gmail.com
Date:   Mon, 10 Jul 2023 21:38:01 +0300
In-Reply-To: <ZKxHfTkgKHYqhBz2@ziepe.ca>
References: <20230710133836.4367-1-mail@eworm.de>
         <20230710142916.18162-1-mail@eworm.de> <ZKxHfTkgKHYqhBz2@ziepe.ca>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-integrity.vger.kernel.org>
X-Mailing-List: linux-integrity@vger.kernel.org

On Mon, 2023-07-10 at 15:01 -0300, Jason Gunthorpe wrote:
> On Mon, Jul 10, 2023 at 04:28:43PM +0200, Christian Hesse wrote:
> > This device suffer an irq storm, so add it in tpm_tis_dmi_table to
> > force polling.
>=20
> I can't help but feel like we are doing something wrong in the Linux
> driver that we keep having IRQ problems.
>=20
> Surely Windows uses the IRQ on these devices? How does it work
> reliably there?
>=20
> Jason

I'm about to send a PR to Linus with a pile of IRQ fixes for v6.4
feature.

BR, Jarkko