From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Mårten Lindahl" <marten.lindahl@axis.com>,
"Peter Huewe" <peterhuewe@gmx.de>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH] tpm: Add check for Failure mode for TPM2 modules
Date: Mon, 25 Apr 2022 17:03:33 +0300 [thread overview]
Message-ID: <3991049ce6859f51e5b61e94de269f4672a568cb.camel@kernel.org> (raw)
In-Reply-To: <20220425102552.663069-1-marten.lindahl@axis.com>
On Mon, 2022-04-25 at 12:25 +0200, Mårten Lindahl wrote:
> In commit 0aa698787aa2 ("tpm: Add Upgrade/Reduced mode support for
> TPM2 modules") it was said that:
>
> "If the TPM is in Failure mode, it will successfully respond to both
> tpm2_do_selftest() and tpm2_startup() calls. Although, will fail to
> answer to tpm2_get_cc_attrs_tbl(). Use this fact to conclude that TPM
> is in Failure mode."
>
> But a check was never added in the commit when calling
> tpm2_get_cc_attrs_tbl() to conclude that the TPM is in Failure mode.
> This commit corrects this by adding a check.
>
> Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
I think this should actually have the fixes tag. It's a regression,
right? I can add it.
BR, Jarkko
next prev parent reply other threads:[~2022-04-25 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 10:25 [PATCH] tpm: Add check for Failure mode for TPM2 modules Mårten Lindahl
2022-04-25 14:03 ` Jarkko Sakkinen [this message]
2022-04-25 15:52 ` Marten Lindahl
2022-05-06 12:00 ` Stefan Mahnke-Hartmann
2022-05-09 13:47 ` Marten Lindahl
2022-05-30 15:26 ` Marten Lindahl
2022-06-01 2:05 ` Jarkko Sakkinen
2022-06-02 11:15 ` Jarkko Sakkinen
2022-06-20 14:59 ` Marten Lindahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3991049ce6859f51e5b61e94de269f4672a568cb.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel@axis.com \
--cc=linux-integrity@vger.kernel.org \
--cc=marten.lindahl@axis.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).