From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 06/12] tpm: export the context save and load commands
Date: Mon, 03 Apr 2023 12:54:41 -0400 [thread overview]
Message-ID: <39ceac9c8dfdb0101bbf386966599fa5d2dc8877.camel@HansenPartnership.com> (raw)
In-Reply-To: <Y/xr53SmY3aDZV2D@kernel.org>
On Mon, 2023-02-27 at 10:37 +0200, Jarkko Sakkinen wrote:
> On Thu, Feb 16, 2023 at 03:14:04PM -0500, James Bottomley wrote:
> > The TPM2 session HMAC and encryption handling code needs to save
> > and restore a single volatile context for the elliptic curve
> > version of the NULL seed, so export the APIs which do this for
> > internal use.
> >
> > Signed-off-by: James Bottomley
> > <James.Bottomley@HansenPartnership.com>
>
> These did not need EXPORT_SYMBOL_GPL()?
No, because they're still internal to the overall tpm.ko even if it is
compiled as a module. I don't think there's a huge reason to keep them
as an internal only to the tpm core API, but equally without a consumer
outside the core module, there's no reason to export them.
James
next prev parent reply other threads:[~2023-04-03 16:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 20:13 [PATCH 00/12] add integrity and security to TPM2 transactions James Bottomley
2023-02-16 20:13 ` [PATCH 01/12] crypto: lib - implement library version of AES in CFB mode James Bottomley
2023-02-27 7:47 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 02/12] tpm: move buffer handling from static inlines to real functions James Bottomley
2023-02-27 8:18 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 03/12] tpm: add buffer handling for TPM2B types James Bottomley
2023-02-27 8:31 ` Jarkko Sakkinen
2023-03-28 19:42 ` James Bottomley
2023-02-16 20:14 ` [PATCH 04/12] tpm: add cursor based buffer functions for response parsing James Bottomley
2023-02-27 8:34 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 05/12] tpm: add buffer function to point to returned parameters James Bottomley
2023-02-27 8:36 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 06/12] tpm: export the context save and load commands James Bottomley
2023-02-27 8:37 ` Jarkko Sakkinen
2023-04-03 16:54 ` James Bottomley [this message]
2023-02-16 20:14 ` [PATCH 07/12] tpm: Add full HMAC and encrypt/decrypt session handling code James Bottomley
2023-02-16 23:37 ` kernel test robot
2023-02-17 11:30 ` kernel test robot
2023-02-17 14:22 ` James Bottomley
2023-02-17 14:23 ` Ard Biesheuvel
2023-02-16 20:14 ` [PATCH 08/12] tpm: add hmac checks to tpm2_pcr_extend() James Bottomley
2023-02-27 9:16 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 09/12] tpm: add session encryption protection to tpm2_get_random() James Bottomley
2023-02-16 20:14 ` [PATCH 10/12] KEYS: trusted: Add session encryption protection to the seal/unseal path James Bottomley
2023-02-16 20:40 ` [PATCH 11/12] tpm: add the null key name as a sysfs export James Bottomley
2023-02-17 10:59 ` kernel test robot
2023-02-16 20:41 ` [PATCH 12/12] Documentation: add tpm-security.rst James Bottomley
2023-02-17 22:43 ` [PATCH 00/12] add integrity and security to TPM2 transactions Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ceac9c8dfdb0101bbf386966599fa5d2dc8877.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).