From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31860C433E0 for ; Wed, 8 Jul 2020 11:02:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B4E62067D for ; Wed, 8 Jul 2020 11:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YS/Nf+ld" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbgGHLB6 (ORCPT ); Wed, 8 Jul 2020 07:01:58 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28877 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728385AbgGHLB5 (ORCPT ); Wed, 8 Jul 2020 07:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594206115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R5NESMLlssU1+fU+MzHpdMP4ATVfk6Mh7mmKV6aiRHE=; b=YS/Nf+ldhQ6NhSsRWzRqzoakNyW4t/dL1YJlj8oBOLXE2ICG8Ob3suSLBmV0foq/wm36Ap 72IKAf1nV0FVsf//3Xl374HcKekFSUOGmcy43OJ91ucFvRykWgnx03NVuTaDd45ShYPEZz I27lDeKIZo4q7+PvRui+o7oCGcR/97w= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-tvBPpLZ9M0S1YXhd1yXIJQ-1; Wed, 08 Jul 2020 07:01:54 -0400 X-MC-Unique: tvBPpLZ9M0S1YXhd1yXIJQ-1 Received: by mail-ed1-f69.google.com with SMTP id d3so44764499edq.14 for ; Wed, 08 Jul 2020 04:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R5NESMLlssU1+fU+MzHpdMP4ATVfk6Mh7mmKV6aiRHE=; b=G+jZAY8x0z/ImvQDUiMv5XXey3Q9s/DsGHz4WFoE3br+MmfQY2MolnY1e70DkFZg7D bjVzzbkRtcXbDWMxPr2KZRd8RbX1ZcecMH5xuMco5Mfzq2rPkV9qNXvG4IROj181i01U Snzo6FxH4QzIHANqxJ5BVvDkuIoN15R6Mg8w0exrwRqEA5ZWyH98Pwiq5ITVzsH099I6 ast22F47pCe8MSEL1O9ECkwkGon7fJXCaxx2KUoi2Vo9Xb5LvVc8LsQIRzT2RmRBS7X7 Uk23NWiFL1N4o1CH/Ti9nFMy+fv7uVe/H237Re5UdeH/BlxDnsFJuASbK7G84c44bODH y7Dg== X-Gm-Message-State: AOAM531Y+ntdCRZ9gRYLwNZjUkTsNCBDHEVGcpd8yvaagELtar/GmQYx H4lbjzJI82Yjh3CuiEC7eRMI74Xq0QJ7E5MysNgn+6p5ZDogV+pSMmLE3HabHwYqsdvUURFBvWD ohGSbpx53gCj+bw9duW23d5o7vZxy X-Received: by 2002:aa7:d297:: with SMTP id w23mr63681844edq.49.1594206112970; Wed, 08 Jul 2020 04:01:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu3h7uw896uTUPxnA3LkPYXdQN/SwlS39PF0fY2ZywJDOPl8R3ZF8j4DbvajdrArtX/ozobQ== X-Received: by 2002:aa7:d297:: with SMTP id w23mr63681803edq.49.1594206112726; Wed, 08 Jul 2020 04:01:52 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id p4sm1776088eja.9.2020.07.08.04.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 04:01:52 -0700 (PDT) Subject: Re: [PATCH 0/4] Fix misused kernel_read_file() enums To: Kees Cook , James Morris Cc: Luis Chamberlain , Mimi Zohar , Scott Branden , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexander Viro , Jessica Yu , Dmitry Kasatkin , "Serge E. Hallyn" , Casey Schaufler , "Eric W. Biederman" , Peter Zijlstra , Matthew Garrett , David Howells , Mauro Carvalho Chehab , Randy Dunlap , "Joel Fernandes (Google)" , KP Singh , Dave Olsthoorn , Peter Jones , Andrew Morton , Stephen Boyd , Paul Moore , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200707081926.3688096-1-keescook@chromium.org> From: Hans de Goede Message-ID: <3c01073b-c422-dd97-0677-c16fe1158907@redhat.com> Date: Wed, 8 Jul 2020 13:01:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200707081926.3688096-1-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi, On 7/7/20 10:19 AM, Kees Cook wrote: > Hi, > > In looking for closely at the additions that got made to the > kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER > and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate > *kinds* of files for the LSM to reason about. They are a "how" and > "where", respectively. Remove these improper aliases and refactor the > code to adapt to the changes. > > Additionally adds in missing calls to security_kernel_post_read_file() > in the platform firmware fallback path (to match the sysfs firmware > fallback path) and in module loading. I considered entirely removing > security_kernel_post_read_file() hook since it is technically unused, > but IMA probably wants to be able to measure EFI-stored firmware images, > so I wired it up and matched it for modules, in case anyone wants to > move the module signature checks out of the module core and into an LSM > to avoid the current layering violations. > > This touches several trees, and I suspect it would be best to go through > James's LSM tree. > > Thanks! I've done some quick tests on this series to make sure that the efi embedded-firmware support did not regress. That still works fine, so this series is; Tested-by: Hans de Goede Regards, Hans > > -Kees > > Kees Cook (4): > firmware_loader: EFI firmware loader must handle pre-allocated buffer > fs: Remove FIRMWARE_PREALLOC_BUFFER from kernel_read_file() enums > fs: Remove FIRMWARE_EFI_EMBEDDED from kernel_read_file() enums > module: Add hook for security_kernel_post_read_file() > > drivers/base/firmware_loader/fallback_platform.c | 12 ++++++++++-- > drivers/base/firmware_loader/main.c | 5 ++--- > fs/exec.c | 7 ++++--- > include/linux/fs.h | 3 +-- > include/linux/lsm_hooks.h | 6 +++++- > kernel/module.c | 7 ++++++- > security/integrity/ima/ima_main.c | 6 ++---- > 7 files changed, 30 insertions(+), 16 deletions(-) >