Re: [PATCH ima-evm-utils] Add tests for MMAP_CHECK and MMAP_CHECK_REQPROT hooks

[Mimi Zohar <zohar@linux.ibm.com>]

On Mon, 2023-01-30 at 17:36 +0100, Roberto Sassu wrote:
> On Mon, 2023-01-30 at 11:26 -0500, Mimi Zohar wrote:
> > On Mon, 2023-01-30 at 15:02 +0100, Roberto Sassu wrote:
> > > On Mon, 2023-01-30 at 08:28 -0500, Mimi Zohar wrote:
> > > > [Trimmed Cc list, since this is an ima-evm-utils discussion.  Adding
> > > > Petr.]
> > > > 
> > > > On Fri, 2023-01-27 at 08:57 +0100, Roberto Sassu wrote:
> > > > > On Thu, 2023-01-26 at 17:25 -0500, Stefan Berger wrote:
> > > > > > How do you tell the user that the patches need to be applied for the test to
> > > > > > succeed and not worry about it when the patches are not applied?
> > > > > 
> > > > > Uhm, I agree. I should at least write a comment as for EVM portable
> > > > > signatures, and maybe display a message in the test logs.
> > > > 
> > > > This is a generic problem that needs to be addressed.  FYI, LTP
> > > > addressed it by introducing "struct test_tag" in commit ca2c76990
> > > > ("lib: Add support for test tags").
> > > 
> > > One idea could be to list all the patches the group of tests is going
> > > to check, and add an argument to expect_pass and expect_fail to specify
> > > the indexes of patches required for the test. We print the required
> > > patches in an error message.
> > 
> > It's not clear to me what is meant by "group of tests".   Is this at
> > the granularity of the test - portable signatures, fsverity,
> > boot_aggregate, etc?  Or, is this at a new grouping of tests?
> 
> Sorry, it wasn't clear. I meant all the tests defined in a test script.

No problems.  I hadn't noticed your subsequent example.
> 
> The idea is to associate a list of array indexes with each test
> (argument of expect_pass() or expect_fail()). The indexes refer to the
> PATCHES variable.
> 
> Theoretically, you could also define PATCHES in a common script, called
> by all test scripts, and specify indexes of that array in the test
> scripts.
> 
> I already have a patch, I could send it. Maybe it is more clear.

Yes, I saw what you meant in the subsequent email.

Mimi