From: Jarkko Sakkinen <jarkko@kernel.org>
To: Christian Hesse <mail@eworm.de>, linux-integrity@vger.kernel.org
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
Lino Sanfilippo <l.sanfilippo@kunbus.com>,
Linux kernel regressions list <regressions@lists.linux.dev>,
Peter Huewe <peterhuewe@gmx.de>,
stable@vger.kernel.org, roubro1991@gmail.com
Subject: Re: [PATCH 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen
Date: Mon, 10 Jul 2023 19:29:21 +0300 [thread overview]
Message-ID: <48da39d3c5cc4be56965ff7515844a761217ffe7.camel@kernel.org> (raw)
In-Reply-To: <20230710133836.4367-1-mail@eworm.de>
On Mon, 2023-07-10 at 15:38 +0200, Christian Hesse wrote:
> This device suffer an irq storm, so add it in tpm_tis_dmi_table to
> force polling.
>
> https://bugs.archlinux.org/user/38129
> https://bugzilla.kernel.org/show_bug.cgi?id=217631
>
> Fixes: e644b2f498d297a928efcb7ff6f900c27f8b788e
> Cc: stable@vger.kernel.org
> Reported-by: <roubro1991@gmail.com>
> Signed-off-by: Christian Hesse <mail@eworm.de>
> ---
> drivers/char/tpm/tpm_tis.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 7db3593941ea..2979f8b9aaa0 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -114,6 +114,14 @@ static int tpm_tis_disable_irq(const struct dmi_system_id *d)
> }
>
> static const struct dmi_system_id tpm_tis_dmi_table[] = {
> + {
> + .callback = tpm_tis_disable_irq,
> + .ident = "Framework Laptop Intel 12th gen",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Framework"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "A4"),
> + },
> + },
> {
> .callback = tpm_tis_disable_irq,
> .ident = "ThinkPad T490s",
Hi, no other issues except fixes tag should be in both:
Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
I.e.
# $1 = commit ID
function git-fixes {
git --no-pager log --format='Fixes: %h ("%s")' --abbrev=12 -1 $1;
}
I'll update them, thank you.
BR, Jarkko
prev parent reply other threads:[~2023-07-10 16:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 7:37 [regression] Kernel 6.4 failing to access TPM on Framework Laptop 12th gen Thorsten Leemhuis
2023-07-10 13:38 ` [PATCH 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel " Christian Hesse
2023-07-10 13:38 ` [PATCH 2/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 13th gen Christian Hesse
2023-07-10 13:56 ` [PATCH 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen Linux regression tracking (Thorsten Leemhuis)
2023-07-10 14:10 ` Greg KH
2023-07-10 14:28 ` [PATCH v2 " Christian Hesse
2023-07-10 14:28 ` [PATCH v2 2/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 13th gen Christian Hesse
2023-07-10 16:52 ` [PATCH v2 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen Linux regression tracking (Thorsten Leemhuis)
2023-07-10 18:01 ` Jason Gunthorpe
2023-07-10 18:38 ` Jarkko Sakkinen
2023-07-11 14:18 ` James Bottomley
2023-07-12 17:00 ` Jerry Snitselaar
2023-07-10 21:13 ` Christian Hesse
2023-07-10 21:16 ` [PATCH v3 " Christian Hesse
2023-07-10 21:16 ` [PATCH v3 2/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 13th gen Christian Hesse
2023-07-10 21:29 ` [PATCH v2 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen Jarkko Sakkinen
2023-07-10 21:51 ` Jarkko Sakkinen
2023-07-12 6:48 ` Christian Hesse
2023-07-17 13:10 ` Jarkko Sakkinen
2023-07-11 12:41 ` Grundik
2023-07-11 13:00 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-11 21:50 ` Jarkko Sakkinen
2023-07-13 15:33 ` Lino Sanfilippo
2023-08-06 16:30 ` Grundik
2023-08-11 8:18 ` Thorsten Leemhuis
2023-08-11 10:44 ` Grundik
2023-08-11 17:46 ` Jarkko Sakkinen
2023-08-11 17:22 ` Jarkko Sakkinen
2023-08-11 17:40 ` Jarkko Sakkinen
2023-08-11 18:47 ` Grundik
2023-08-11 20:01 ` Jarkko Sakkinen
2023-08-12 11:28 ` Grundik
2023-08-14 17:33 ` Jarkko Sakkinen
2023-08-11 18:55 ` Linus Torvalds
2023-08-11 19:28 ` Jarkko Sakkinen
2023-07-10 16:29 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48da39d3c5cc4be56965ff7515844a761217ffe7.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mail@eworm.de \
--cc=peterhuewe@gmx.de \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=roubro1991@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).