public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Kamlesh Kumar <kamlesh0hrs@gmail.com>
Cc: ebiggers@kernel.org, linux-integrity@vger.kernel.org,
	stefanb@linux.ibm.com, Kamlesh Kumar <kam@juniper.net>
Subject: Re: [PATCH 0/3] ima: add regular file data hash support for sigv3
Date: Mon, 27 Apr 2026 09:30:20 -0400	[thread overview]
Message-ID: <4a6cec5383a6df072e7cf14ef885ac9b08952455.camel@linux.ibm.com> (raw)
In-Reply-To: <20260427125743.35245-1-kam@juniper.net>

On Mon, 2026-04-27 at 18:27 +0530, Kamlesh Kumar wrote:
> On 3/24/26 4:39 PM, Mimi Zohar wrote:
> > IMA signature version 3 (sigv3) support was introduced to avoid file
> > signature ambiguity. Instead of directly signing a raw fs-verity hash,
> > IMA signs the hash of ima_file_id structure, containing the type of
> > signature, the hash algorithm, and the hash.
> > 
> > Pure ML-DSA calculates and signs the hash directly rather than a
> > pre-hashed digest. To avoid ML-DSA having to re-calculate the file data
> > hash, Eric Biggers suggested signing the smaller ima_file_id structure.
> > 
> > This patch set adds the sigv3 support for regular file data hashes. A
> > subsequent patch set will add the ML-DSA support.
> > 
> > Mimi Zohar (3):
> >    ima: Define asymmetric_verify_v3() to verify IMA sigv3 signatures
> >    ima: add regular file data hash signature version 3 support
> >    ima: add support to require IMA sigv3 signatures
> > 
> >   Documentation/ABI/testing/ima_policy   | 10 ++--
> >   security/integrity/digsig.c            |  8 +--
> >   security/integrity/digsig_asymmetric.c | 58 +++++++++++++++++++++
> >   security/integrity/evm/evm_main.c      |  3 +-
> >   security/integrity/ima/ima.h           |  1 +
> >   security/integrity/ima/ima_appraise.c  | 72 ++++++++------------------
> >   security/integrity/ima/ima_policy.c    | 22 ++++----
> >   security/integrity/integrity.h         | 14 ++++-
> >   8 files changed, 115 insertions(+), 73 deletions(-)
> > 
> > --
> > 2.53.0
> > 
> 
> I have tested this series along with Stefan's ML-DSA patches [1] and an
> additional fix [2] for ima_get_hash_algo().
> With all patches applied, I am able to successfully sign files with
> ML-DSA-65 and verify IMA sigv3 signatures during appraisal.
> 
> [1] https://lore.kernel.org/linux-integrity/20260405231224.4008298-1-stefanb@linux.ibm.com/
> [2] https://lore.kernel.org/linux-integrity/20260424110751.5637-1-kam@juniper.net/
> 
> Tested-by: Kamlesh Kumar <kam@juniper.net>

Thanks, Kamlesh!

I'd appreciate re-testing with the v3 version now queued in next-integrity-
testing
https://lore.kernel.org/linux-integrity/20260416154039.1648083-1-stefanb@linux.ibm.com
?

Mimi

      reply	other threads:[~2026-04-27 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 20:39 [PATCH 0/3] ima: add regular file data hash support for sigv3 Mimi Zohar
2026-03-24 20:39 ` [PATCH 1/3] ima: Define asymmetric_verify_v3() to verify IMA sigv3 signatures Mimi Zohar
2026-03-30 20:13   ` Eric Biggers
2026-04-05  9:46     ` Mimi Zohar
2026-03-24 20:39 ` [PATCH 2/3] ima: add regular file data hash signature version 3 support Mimi Zohar
2026-03-24 20:39 ` [PATCH 3/3] ima: add support to require IMA sigv3 signatures Mimi Zohar
2026-03-25  0:15 ` [PATCH 0/3] ima: add regular file data hash support for sigv3 Stefan Berger
2026-03-30 20:16 ` Eric Biggers
2026-04-27 12:57 ` Kamlesh Kumar
2026-04-27 13:30   ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a6cec5383a6df072e7cf14ef885ac9b08952455.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=ebiggers@kernel.org \
    --cc=kam@juniper.net \
    --cc=kamlesh0hrs@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox