From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74328C3A59F for ; Tue, 27 Aug 2019 00:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5054F2070B for ; Tue, 27 Aug 2019 00:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbfH0A6w (ORCPT ); Mon, 26 Aug 2019 20:58:52 -0400 Received: from gloria.sntech.de ([185.11.138.130]:56606 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfH0A6w (ORCPT ); Mon, 26 Aug 2019 20:58:52 -0400 Received: from c-73-71-116-68.hsd1.ca.comcast.net ([73.71.116.68] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2Pou-0007GJ-PT; Tue, 27 Aug 2019 02:58:49 +0200 From: Heiko Stuebner To: Stephen Boyd Cc: Peter Huewe , Jarkko Sakkinen , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Andrey Pronin , Duncan Laurie , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Alexander Steffen Subject: Re: [PATCH v4 0/6] tpm: Add driver for cr50 Date: Tue, 27 Aug 2019 02:58:43 +0200 Message-ID: <5576462.WM6bgkPhtz@phil> In-Reply-To: <20190812223622.73297-1-swboyd@chromium.org> References: <20190812223622.73297-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Am Dienstag, 13. August 2019, 00:36:16 CEST schrieb Stephen Boyd: > This patch series adds support for the the H1 secure microcontroller > running cr50 firmware found on various recent Chromebooks. This driver > is necessary to boot into a ChromeOS userspace environment. It > implements support for several functions, including TPM-like > functionality over a SPI interface. > > The last time this was series sent looks to be [1]. I've looked over the > patches and review comments and tried to address any feedback that > Andrey didn't address (really minor things like newlines). I've reworked > the patches from the last version to layer on top of the existing TPM > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more > palatable than combining the two drivers together into one file. > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@chromium.org Gave this a spin on a rk3399-gru-scarlet and it seems to have worked fine and tpm2-tools was happy talking to it, so Tested-by: Heiko Stuebner >From looking through the patches everything also looks nice and peachy but my tpm-insights are limited so I don't really feel comfortable with a RB. Heiko